Skip to content

Commit f5ca22f

Browse files
stephenpluspluscallmehiphop
authored andcommitted
1 parent e4d991a commit f5ca22f

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

lib/common/grpc-service.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ GrpcService.prototype.request = function(protoOpts, reqOpts, callback) {
266266
request: function(_, onResponse) {
267267
respError = null;
268268

269-
service[protoOpts.method](reqOpts, function(err, resp) {
269+
service[protoOpts.method](reqOpts, grpcOpts, function(err, resp) {
270270
if (err) {
271271
if (HTTP_ERROR_CODE_MAP[err.code]) {
272272
respError = extend(err, HTTP_ERROR_CODE_MAP[err.code]);
@@ -279,7 +279,7 @@ GrpcService.prototype.request = function(protoOpts, reqOpts, callback) {
279279
}
280280

281281
onResponse(null, resp);
282-
}, null, grpcOpts);
282+
});
283283
}
284284
}, function(err, resp) {
285285
if (!err && resp === respError) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
"gcs-resumable-upload": "^0.5.0",
104104
"google-auto-auth": "^0.2.0",
105105
"google-proto-files": "^0.1.1",
106-
"grpc": "^0.13.1",
106+
"grpc": "^0.14.1",
107107
"hash-stream-validation": "^0.1.0",
108108
"is": "^3.0.1",
109109
"methmeth": "^1.0.0",

system-test/pubsub.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ describe('pubsub', function() {
361361
assert.ifError(err);
362362

363363
assert.deepEqual(policy.bindings, []);
364-
assert.strictEqual(policy.etag.toString(), '\u0000 \u0001');
364+
assert.strictEqual(policy.etag, 'ACAB');
365365
assert.strictEqual(policy.version, 0);
366366

367367
done();

test/common/grpc-service.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ describe('GrpcService', function() {
522522
grpcService.protos.Service = {
523523
service: function() {
524524
return {
525-
method: function(reqOpts, callback) {
525+
method: function(reqOpts, grpcOpts, callback) {
526526
callback(grpcError500);
527527
}
528528
};
@@ -547,7 +547,7 @@ describe('GrpcService', function() {
547547
grpcService.protos.Service = {
548548
service: function() {
549549
return {
550-
method: function(reqOpts, callback) {
550+
method: function(reqOpts, grpcOpts, callback) {
551551
callback(grpcError500);
552552
}
553553
};
@@ -590,7 +590,7 @@ describe('GrpcService', function() {
590590
grpcService.protos.Service = {
591591
service: function() {
592592
return {
593-
method: function(reqOpts, callback, _, grpcOpts) {
593+
method: function(reqOpts, grpcOpts) {
594594
assert(is.date(grpcOpts.deadline));
595595

596596
assert(grpcOpts.deadline.getTime() > expectedDeadlineRange[0]);
@@ -634,7 +634,7 @@ describe('GrpcService', function() {
634634
grpcService.protos.Service = {
635635
service: function() {
636636
return {
637-
method: function(reqOpts, callback) {
637+
method: function(reqOpts, grpcOpts, callback) {
638638
callback(grpcError);
639639
}
640640
};
@@ -657,7 +657,7 @@ describe('GrpcService', function() {
657657
grpcService.protos.Service = {
658658
service: function() {
659659
return {
660-
method: function(reqOpts, callback) {
660+
method: function(reqOpts, grpcOpts, callback) {
661661
callback(null, RESPONSE);
662662
}
663663
};

0 commit comments

Comments
 (0)