Skip to content

Commit ef97efa

Browse files
renovate[bot]JustinBeckwith
authored andcommitted
fix(deps): update dependency @google-cloud/common to ^0.30.0 (#205)
1 parent f1013ff commit ef97efa

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

packages/google-cloud-dns/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"scripts": {
3333
"docs": "jsdoc -c .jsdoc.js",
3434
"generate-scaffolding": "repo-tools generate all && repo-tools generate lib_samples_readme -l samples/ --config ../.cloud-repo-tools.json",
35-
"lint": "gts check && eslint samples/",
35+
"lint": "gts check && eslint '**/*.js'",
3636
"test": "nyc mocha build/test",
3737
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
3838
"presystem-test": "npm run compile",
@@ -44,7 +44,7 @@
4444
"pretest": "npm run compile"
4545
},
4646
"dependencies": {
47-
"@google-cloud/common": "^0.29.0",
47+
"@google-cloud/common": "^0.30.0",
4848
"@google-cloud/paginator": "^0.1.0",
4949
"@google-cloud/promisify": "^0.3.0",
5050
"arrify": "^1.0.1",
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
---
22
rules:
33
no-console: off
4+
node/no-missing-require: off

packages/google-cloud-dns/samples/package.json

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
"engines": {
88
"node": ">=8"
99
},
10+
"files": [
11+
"*.js"
12+
],
1013
"scripts": {
1114
"test": "mocha system-test --timeout 600000"
1215
},

packages/google-cloud-dns/system-test/dns.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import * as uuid from 'uuid';
2424
const format = require('string-format-obj');
2525

2626
import {DNS, Record} from '../src';
27+
import {Metadata} from '@google-cloud/common';
2728

2829
const dns = new DNS();
2930
const DNS_DOMAIN = process.env.GCLOUD_TESTS_DNS_DOMAIN || 'gitnpm.com.';
@@ -128,7 +129,7 @@ describe('dns', () => {
128129

129130
describe('Zones', () => {
130131
it('should get the metadata for a zone', done => {
131-
ZONE.getMetadata((err, metadata) => {
132+
ZONE.getMetadata((err: Error, metadata: Metadata) => {
132133
assert.ifError(err);
133134
assert.strictEqual(metadata.name, ZONE_NAME);
134135
done();
@@ -236,7 +237,7 @@ describe('dns', () => {
236237
assert.ifError(err);
237238
const change = changes![0];
238239
const expectedMetadata = change.metadata;
239-
change.getMetadata((err, metadata) => {
240+
change.getMetadata((err: Error, metadata: Metadata) => {
240241
assert.ifError(err);
241242
delete metadata.status;
242243
delete expectedMetadata.status;

0 commit comments

Comments
 (0)