Skip to content

Commit d9ccb53

Browse files
feat: added support for k8s_version field (#130)
* feat: added support for k8s_version field docs: k8s_version field is not part of resource_options struct Clients now generate the V1 or V1beta1 CRD based on Kubernetes server version. PiperOrigin-RevId: 430569173 Source-Link: googleapis/googleapis@3c17193 Source-Link: googleapis/googleapis-gen@ae78440 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU3ODQ0MDZlMzAwYmYxYzU2ZDUwMTExMzM4YjkyNzJmYjA0NzNiNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent ff0c4d0 commit d9ccb53

11 files changed

+235
-156
lines changed

packages/google-cloud-gkehub/protos/google/cloud/gkehub/v1beta1/membership.proto

+134-95
Large diffs are not rendered by default.

packages/google-cloud-gkehub/protos/protos.d.ts

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-gkehub/protos/protos.js

+22
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-gkehub/protos/protos.json

+7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-gkehub/samples/generated/v1beta1/gke_hub_membership_service.create_membership.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ function main(parent, membershipId, resource) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The parent (project and location) where the Memberships will be created.
30-
* Specified in the format `projects/* /locations/*`.
29+
* Required. The parent (project and location) where the Memberships will be
30+
* created. Specified in the format `projects/* /locations/*`.
3131
*/
3232
// const parent = 'abc123'
3333
/**
34-
* Required. Client chosen ID for the membership. `membership_id` must be a valid RFC
35-
* 1123 compliant DNS label:
34+
* Required. Client chosen ID for the membership. `membership_id` must be a
35+
* valid RFC 1123 compliant DNS label:
3636
* 1. At most 63 characters in length
3737
* 2. It must consist of lower case alphanumeric characters or `-`
3838
* 3. It must start and end with an alphanumeric character

packages/google-cloud-gkehub/samples/generated/v1beta1/gke_hub_membership_service.generate_connect_manifest.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,17 @@ function main(name) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The Membership resource name the Agent will associate with, in the format
30-
* `projects/* /locations/* /memberships/*`.
29+
* Required. The Membership resource name the Agent will associate with, in
30+
* the format `projects/* /locations/* /memberships/*`.
3131
*/
3232
// const name = 'abc123'
3333
/**
3434
* Optional. The connect agent to generate manifest for.
3535
*/
3636
// const connectAgent = {}
3737
/**
38-
* Optional. The Connect agent version to use. Defaults to the most current version.
38+
* Optional. The Connect agent version to use. Defaults to the most current
39+
* version.
3940
*/
4041
// const version = 'abc123'
4142
/**

packages/google-cloud-gkehub/samples/generated/v1beta1/gke_hub_membership_service.list_memberships.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ function main(parent) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The parent (project and location) where the Memberships will be listed.
30-
* Specified in the format `projects/* /locations/*`.
29+
* Required. The parent (project and location) where the Memberships will be
30+
* listed. Specified in the format `projects/* /locations/*`.
3131
*/
3232
// const parent = 'abc123'
3333
/**
34-
* Optional. When requesting a 'page' of resources, `page_size` specifies number of
35-
* resources to return. If unspecified or set to 0, all resources will
36-
* be returned.
34+
* Optional. When requesting a 'page' of resources, `page_size` specifies
35+
* number of resources to return. If unspecified or set to 0, all resources
36+
* will be returned.
3737
*/
3838
// const pageSize = 1234
3939
/**
@@ -43,8 +43,8 @@ function main(parent) {
4343
*/
4444
// const pageToken = 'abc123'
4545
/**
46-
* Optional. Lists Memberships that match the filter expression, following the syntax
47-
* outlined in https://google.aip.dev/160.
46+
* Optional. Lists Memberships that match the filter expression, following the
47+
* syntax outlined in https://google.aip.dev/160.
4848
* Examples:
4949
* - Name is `bar` in project `foo-proj` and location `global`:
5050
* name = "projects/foo-proj/locations/global/membership/bar"

packages/google-cloud-gkehub/samples/generated/v1beta1/gke_hub_membership_service.update_membership.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ function main(name, updateMask, resource) {
3131
*/
3232
// const name = 'abc123'
3333
/**
34-
* Required. Mask of fields to update. At least one field path must be specified in this
35-
* mask.
34+
* Required. Mask of fields to update. At least one field path must be
35+
* specified in this mask.
3636
*/
3737
// const updateMask = {}
3838
/**

packages/google-cloud-gkehub/samples/generated/v1beta1/gke_hub_membership_service.validate_exclusivity.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,19 @@ function main(parent, intendedMembership) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The parent (project and location) where the Memberships will be created.
30-
* Specified in the format `projects/* /locations/*`.
29+
* Required. The parent (project and location) where the Memberships will be
30+
* created. Specified in the format `projects/* /locations/*`.
3131
*/
3232
// const parent = 'abc123'
3333
/**
34-
* Optional. The YAML of the membership CR in the cluster. Empty if the membership
35-
* CR does not exist.
34+
* Optional. The YAML of the membership CR in the cluster. Empty if the
35+
* membership CR does not exist.
3636
*/
3737
// const crManifest = 'abc123'
3838
/**
39-
* Required. The intended membership name under the `parent`. This method only does
40-
* validation in anticipation of a CreateMembership call with the same name.
39+
* Required. The intended membership name under the `parent`. This method only
40+
* does validation in anticipation of a CreateMembership call with the same
41+
* name.
4142
*/
4243
// const intendedMembership = 'abc123'
4344

packages/google-cloud-gkehub/samples/generated/v1beta1/snippet_metadata.google.cloud.gkehub.v1beta1.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@
266266
"segments": [
267267
{
268268
"start": 25,
269-
"end": 73,
269+
"end": 74,
270270
"type": "FULL"
271271
}
272272
],
@@ -326,7 +326,7 @@
326326
"segments": [
327327
{
328328
"start": 25,
329-
"end": 62,
329+
"end": 63,
330330
"type": "FULL"
331331
}
332332
],

packages/google-cloud-gkehub/src/v1beta1/gke_hub_membership_service_client.ts

+40-37
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ const version = require('../../../package.json').version;
4343

4444
/**
4545
* The GKE Hub MembershipService handles the registration of many Kubernetes
46-
* clusters to Google Cloud, represented with the {@link google.cloud.gkehub.v1beta1.Membership|Membership} resource.
46+
* clusters to Google Cloud, represented with the
47+
* {@link google.cloud.gkehub.v1beta1.Membership|Membership} resource.
4748
*
4849
* GKE Hub is currently only available in the global region.
4950
*
@@ -484,12 +485,13 @@ export class GkeHubMembershipServiceClient {
484485
* @param {Object} request
485486
* The request object that will be sent.
486487
* @param {string} request.name
487-
* Required. The Membership resource name the Agent will associate with, in the format
488-
* `projects/* /locations/* /memberships/*`.
488+
* Required. The Membership resource name the Agent will associate with, in
489+
* the format `projects/* /locations/* /memberships/*`.
489490
* @param {google.cloud.gkehub.v1beta1.ConnectAgent} [request.connectAgent]
490491
* Optional. The connect agent to generate manifest for.
491492
* @param {string} [request.version]
492-
* Optional. The Connect agent version to use. Defaults to the most current version.
493+
* Optional. The Connect agent version to use. Defaults to the most current
494+
* version.
493495
* @param {boolean} [request.isUpgrade]
494496
* Optional. If true, generate the resources for upgrade only. Some resources
495497
* generated only for installation (e.g. secrets) will be excluded.
@@ -599,14 +601,15 @@ export class GkeHubMembershipServiceClient {
599601
* @param {Object} request
600602
* The request object that will be sent.
601603
* @param {string} request.parent
602-
* Required. The parent (project and location) where the Memberships will be created.
603-
* Specified in the format `projects/* /locations/*`.
604+
* Required. The parent (project and location) where the Memberships will be
605+
* created. Specified in the format `projects/* /locations/*`.
604606
* @param {string} [request.crManifest]
605-
* Optional. The YAML of the membership CR in the cluster. Empty if the membership
606-
* CR does not exist.
607+
* Optional. The YAML of the membership CR in the cluster. Empty if the
608+
* membership CR does not exist.
607609
* @param {string} request.intendedMembership
608-
* Required. The intended membership name under the `parent`. This method only does
609-
* validation in anticipation of a CreateMembership call with the same name.
610+
* Required. The intended membership name under the `parent`. This method only
611+
* does validation in anticipation of a CreateMembership call with the same
612+
* name.
610613
* @param {object} [options]
611614
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
612615
* @returns {Promise} - The promise which resolves to an array.
@@ -829,11 +832,11 @@ export class GkeHubMembershipServiceClient {
829832
* @param {Object} request
830833
* The request object that will be sent.
831834
* @param {string} request.parent
832-
* Required. The parent (project and location) where the Memberships will be created.
833-
* Specified in the format `projects/* /locations/*`.
835+
* Required. The parent (project and location) where the Memberships will be
836+
* created. Specified in the format `projects/* /locations/*`.
834837
* @param {string} request.membershipId
835-
* Required. Client chosen ID for the membership. `membership_id` must be a valid RFC
836-
* 1123 compliant DNS label:
838+
* Required. Client chosen ID for the membership. `membership_id` must be a
839+
* valid RFC 1123 compliant DNS label:
837840
*
838841
* 1. At most 63 characters in length
839842
* 2. It must consist of lower case alphanumeric characters or `-`
@@ -1152,8 +1155,8 @@ export class GkeHubMembershipServiceClient {
11521155
* Required. The membership resource name in the format:
11531156
* `projects/[project_id]/locations/global/memberships/[membership_id]`
11541157
* @param {google.protobuf.FieldMask} request.updateMask
1155-
* Required. Mask of fields to update. At least one field path must be specified in this
1156-
* mask.
1158+
* Required. Mask of fields to update. At least one field path must be
1159+
* specified in this mask.
11571160
* @param {google.cloud.gkehub.v1beta1.Membership} request.resource
11581161
* Required. Only fields specified in update_mask are updated.
11591162
* If you specify a field in the update_mask but don't specify its value here
@@ -1313,19 +1316,19 @@ export class GkeHubMembershipServiceClient {
13131316
* @param {Object} request
13141317
* The request object that will be sent.
13151318
* @param {string} request.parent
1316-
* Required. The parent (project and location) where the Memberships will be listed.
1317-
* Specified in the format `projects/* /locations/*`.
1319+
* Required. The parent (project and location) where the Memberships will be
1320+
* listed. Specified in the format `projects/* /locations/*`.
13181321
* @param {number} [request.pageSize]
1319-
* Optional. When requesting a 'page' of resources, `page_size` specifies number of
1320-
* resources to return. If unspecified or set to 0, all resources will
1321-
* be returned.
1322+
* Optional. When requesting a 'page' of resources, `page_size` specifies
1323+
* number of resources to return. If unspecified or set to 0, all resources
1324+
* will be returned.
13221325
* @param {string} [request.pageToken]
13231326
* Optional. Token returned by previous call to `ListMemberships` which
13241327
* specifies the position in the list from where to continue listing the
13251328
* resources.
13261329
* @param {string} [request.filter]
1327-
* Optional. Lists Memberships that match the filter expression, following the syntax
1328-
* outlined in https://google.aip.dev/160.
1330+
* Optional. Lists Memberships that match the filter expression, following the
1331+
* syntax outlined in https://google.aip.dev/160.
13291332
*
13301333
* Examples:
13311334
*
@@ -1440,19 +1443,19 @@ export class GkeHubMembershipServiceClient {
14401443
* @param {Object} request
14411444
* The request object that will be sent.
14421445
* @param {string} request.parent
1443-
* Required. The parent (project and location) where the Memberships will be listed.
1444-
* Specified in the format `projects/* /locations/*`.
1446+
* Required. The parent (project and location) where the Memberships will be
1447+
* listed. Specified in the format `projects/* /locations/*`.
14451448
* @param {number} [request.pageSize]
1446-
* Optional. When requesting a 'page' of resources, `page_size` specifies number of
1447-
* resources to return. If unspecified or set to 0, all resources will
1448-
* be returned.
1449+
* Optional. When requesting a 'page' of resources, `page_size` specifies
1450+
* number of resources to return. If unspecified or set to 0, all resources
1451+
* will be returned.
14491452
* @param {string} [request.pageToken]
14501453
* Optional. Token returned by previous call to `ListMemberships` which
14511454
* specifies the position in the list from where to continue listing the
14521455
* resources.
14531456
* @param {string} [request.filter]
1454-
* Optional. Lists Memberships that match the filter expression, following the syntax
1455-
* outlined in https://google.aip.dev/160.
1457+
* Optional. Lists Memberships that match the filter expression, following the
1458+
* syntax outlined in https://google.aip.dev/160.
14561459
*
14571460
* Examples:
14581461
*
@@ -1515,19 +1518,19 @@ export class GkeHubMembershipServiceClient {
15151518
* @param {Object} request
15161519
* The request object that will be sent.
15171520
* @param {string} request.parent
1518-
* Required. The parent (project and location) where the Memberships will be listed.
1519-
* Specified in the format `projects/* /locations/*`.
1521+
* Required. The parent (project and location) where the Memberships will be
1522+
* listed. Specified in the format `projects/* /locations/*`.
15201523
* @param {number} [request.pageSize]
1521-
* Optional. When requesting a 'page' of resources, `page_size` specifies number of
1522-
* resources to return. If unspecified or set to 0, all resources will
1523-
* be returned.
1524+
* Optional. When requesting a 'page' of resources, `page_size` specifies
1525+
* number of resources to return. If unspecified or set to 0, all resources
1526+
* will be returned.
15241527
* @param {string} [request.pageToken]
15251528
* Optional. Token returned by previous call to `ListMemberships` which
15261529
* specifies the position in the list from where to continue listing the
15271530
* resources.
15281531
* @param {string} [request.filter]
1529-
* Optional. Lists Memberships that match the filter expression, following the syntax
1530-
* outlined in https://google.aip.dev/160.
1532+
* Optional. Lists Memberships that match the filter expression, following the
1533+
* syntax outlined in https://google.aip.dev/160.
15311534
*
15321535
* Examples:
15331536
*

0 commit comments

Comments
 (0)