Skip to content

Commit d4f066d

Browse files
committed
Merge pull request #798 from stephenplusplus/spp--storage-acl-fixes
Test index.js file
2 parents 4b69f3b + 8b64893 commit d4f066d

File tree

6 files changed

+396
-176
lines changed

6 files changed

+396
-176
lines changed

docs/site/components/docs/docs.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ <h2 ng-if="method.name[0].toUpperCase() === method.name[0]">
6868
<span class="view-code-link" docs-code-link></span>
6969
</h3>
7070
<p ng-if="method.description" ng-bind-html="method.description"></p>
71-
<div ng-show="method.name[0].toUpperCase() === method.name[0]"
71+
<div ng-show="method.constructor"
7272
class="notice">
7373
Available methods:
7474
<span ng-repeat="method in methods">
75-
<span ng-show="method.name[0].toUpperCase() !== method.name[0]">
75+
<span ng-show="$index > 0">
7676
<a href="{{activeUrl + '?method=' + method.name}}"
7777
>{{method.name}}</a>{{$last ? '' : ', '}}
7878
</span>

docs/site/components/docs/docs.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,15 @@ angular
266266
}
267267

268268
function compareMethods(a, b) {
269-
return a.constructor ? -1: a.name > b.name ? 1 : -1;
269+
if (a.constructor) {
270+
return -1;
271+
}
272+
273+
if (b.constructor) {
274+
return 1;
275+
}
276+
277+
return a.name > b.name ? 1 : -1;
270278
}
271279

272280
$routeProvider

lib/common/util.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ util.missingProjectIdError = missingProjectIdError;
6262
* latter is preferred.
6363
*
6464
* @param {object} globalConfig - The global configuration object.
65-
* @param {object} overrides - The instantiation-time configuration object.
65+
* @param {object=} overrides - The instantiation-time configuration object.
6666
* @return {object}
6767
*
6868
* @example
@@ -83,11 +83,15 @@ util.missingProjectIdError = missingProjectIdError;
8383
function extendGlobalConfig(globalConfig, overrides) {
8484
var options = extend({}, globalConfig);
8585
var hasGlobalConnection = options.credentials || options.keyFilename;
86+
87+
overrides = overrides || {};
8688
var isOverridingConnection = overrides.credentials || overrides.keyFilename;
89+
8790
if (hasGlobalConnection && isOverridingConnection) {
8891
delete options.credentials;
8992
delete options.keyFilename;
9093
}
94+
9195
return extend(true, {}, options, overrides);
9296
}
9397

0 commit comments

Comments
 (0)