Skip to content

Commit cb1fa83

Browse files
jkwluijkwlui
authored
chore: assert.deelEqual => assert.deepStrictEqual (#77)
* chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * style: npm run prettier
1 parent 5f2b031 commit cb1fa83

File tree

5 files changed

+29
-26
lines changed

5 files changed

+29
-26
lines changed

‎packages/google-cloud-dns/system-test/dns.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ const DNS_DOMAIN = process.env.GCLOUD_TESTS_DNS_DOMAIN;
259259

260260
const addition = change.metadata.additions[0];
261261
delete addition.kind;
262-
assert.deepEqual(addition, record.toJSON());
262+
assert.deepStrictEqual(addition, record.toJSON());
263263

264264
done();
265265
});
@@ -285,7 +285,7 @@ const DNS_DOMAIN = process.env.GCLOUD_TESTS_DNS_DOMAIN;
285285

286286
delete metadata.status;
287287
delete expectedMetadata.status;
288-
assert.deepEqual(metadata, expectedMetadata);
288+
assert.deepStrictEqual(metadata, expectedMetadata);
289289

290290
done();
291291
});
@@ -363,8 +363,8 @@ const DNS_DOMAIN = process.env.GCLOUD_TESTS_DNS_DOMAIN;
363363
const deleted = change.metadata.deletions[0].rrdatas;
364364
const added = change.metadata.additions[0].rrdatas;
365365

366-
assert.deepEqual(deleted, originalData);
367-
assert.deepEqual(added, newRecord.data);
366+
assert.deepStrictEqual(deleted, originalData);
367+
assert.deepStrictEqual(added, newRecord.data);
368368

369369
done();
370370
});

‎packages/google-cloud-dns/test/change.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe('Change', function() {
7272
assert.strictEqual(calledWith.parent, ZONE);
7373
assert.strictEqual(calledWith.baseUrl, '/changes');
7474
assert.strictEqual(calledWith.id, CHANGE_ID);
75-
assert.deepEqual(calledWith.methods, {
75+
assert.deepStrictEqual(calledWith.methods, {
7676
exists: true,
7777
get: true,
7878
getMetadata: true,

‎packages/google-cloud-dns/test/index.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const fakePaginator = {
3434
extended = true;
3535
methods = arrify(methods);
3636
assert.strictEqual(Class.name, 'DNS');
37-
assert.deepEqual(methods, ['getZones']);
37+
assert.deepStrictEqual(methods, ['getZones']);
3838
},
3939
streamify: function(methodName) {
4040
return methodName;
@@ -57,7 +57,7 @@ const fakeUtil = extend({}, util, {
5757
}
5858

5959
promisified = true;
60-
assert.deepEqual(options.exclude, ['zone']);
60+
assert.deepStrictEqual(options.exclude, ['zone']);
6161
},
6262
});
6363
const originalFakeUtil = extend(true, {}, fakeUtil);
@@ -130,11 +130,14 @@ describe('DNS', function() {
130130

131131
const baseUrl = 'https://www.googleapis.com/dns/v1';
132132
assert.strictEqual(calledWith.baseUrl, baseUrl);
133-
assert.deepEqual(calledWith.scopes, [
133+
assert.deepStrictEqual(calledWith.scopes, [
134134
'https://www.googleapis.com/auth/ndev.clouddns.readwrite',
135135
'https://www.googleapis.com/auth/cloud-platform',
136136
]);
137-
assert.deepEqual(calledWith.packageJson, require('../package.json'));
137+
assert.deepStrictEqual(
138+
calledWith.packageJson,
139+
require('../package.json')
140+
);
138141
});
139142
});
140143

@@ -187,7 +190,7 @@ describe('DNS', function() {
187190
name: zoneName,
188191
description: '',
189192
});
190-
assert.deepEqual(reqOpts.json, expectedBody);
193+
assert.deepStrictEqual(reqOpts.json, expectedBody);
191194

192195
done();
193196
};
@@ -343,9 +346,9 @@ describe('DNS', function() {
343346
assert.ifError(err);
344347

345348
// Check the original query wasn't modified.
346-
assert.deepEqual(query, originalQuery);
349+
assert.deepStrictEqual(query, originalQuery);
347350

348-
assert.deepEqual(
351+
assert.deepStrictEqual(
349352
nextQuery,
350353
extend({}, query, {
351354
pageToken: apiResponseWithNextPageToken.nextPageToken,

‎packages/google-cloud-dns/test/record.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const fakeUtil = extend({}, util, {
2929
}
3030

3131
promisified = true;
32-
assert.deepEqual(options.exclude, ['toJSON', 'toString']);
32+
assert.deepStrictEqual(options.exclude, ['toJSON', 'toString']);
3333
},
3434
});
3535

@@ -111,7 +111,7 @@ describe('Record', function() {
111111
const record = Record.fromZoneRecord_(ZONE, 'a', aRecord);
112112

113113
assert.strictEqual(record.type, 'A');
114-
assert.deepEqual(record.metadata.data, expectedData);
114+
assert.deepStrictEqual(record.metadata.data, expectedData);
115115
assert.strictEqual(record.metadata.name, aRecord.name);
116116
assert.strictEqual(record.metadata.ttl, aRecord.ttl);
117117
});
@@ -312,7 +312,7 @@ describe('Record', function() {
312312
});
313313
delete expectedRecord.data;
314314

315-
assert.deepEqual(record.toJSON(), expectedRecord);
315+
assert.deepStrictEqual(record.toJSON(), expectedRecord);
316316
});
317317
});
318318

‎packages/google-cloud-dns/test/zone.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const fakeUtil = extend({}, util, {
3535
}
3636

3737
promisified = true;
38-
assert.deepEqual(options.exclude, ['change', 'record']);
38+
assert.deepStrictEqual(options.exclude, ['change', 'record']);
3939
},
4040
});
4141

@@ -87,7 +87,7 @@ const fakePaginator = {
8787
extended = true;
8888
methods = arrify(methods);
8989
assert.strictEqual(Class.name, 'Zone');
90-
assert.deepEqual(methods, ['getChanges', 'getRecords']);
90+
assert.deepStrictEqual(methods, ['getChanges', 'getRecords']);
9191
},
9292
streamify: function(methodName) {
9393
return methodName;
@@ -160,7 +160,7 @@ describe('Zone', function() {
160160
assert.strictEqual(calledWith.parent, dnsInstance);
161161
assert.strictEqual(calledWith.baseUrl, '/managedZones');
162162
assert.strictEqual(calledWith.id, ZONE_NAME);
163-
assert.deepEqual(calledWith.methods, {
163+
assert.deepStrictEqual(calledWith.methods, {
164164
create: true,
165165
exists: true,
166166
get: true,
@@ -225,7 +225,7 @@ describe('Zone', function() {
225225

226226
zone.request = function(reqOpts) {
227227
assert.strictEqual(reqOpts.json.add, undefined);
228-
assert.deepEqual(reqOpts.json.additions, expectedAdditions);
228+
assert.deepStrictEqual(reqOpts.json.additions, expectedAdditions);
229229
done();
230230
};
231231

@@ -239,7 +239,7 @@ describe('Zone', function() {
239239

240240
zone.request = function(reqOpts) {
241241
assert.strictEqual(reqOpts.json.delete, undefined);
242-
assert.deepEqual(reqOpts.json.deletions, expectedDeletions);
242+
assert.deepStrictEqual(reqOpts.json.deletions, expectedDeletions);
243243
done();
244244
};
245245

@@ -370,7 +370,7 @@ describe('Zone', function() {
370370
const recordsToDelete = 'ns';
371371

372372
zone.deleteRecordsByType_ = function(types, callback) {
373-
assert.deepEqual(types, [recordsToDelete]);
373+
assert.deepStrictEqual(types, [recordsToDelete]);
374374
callback();
375375
};
376376

@@ -381,7 +381,7 @@ describe('Zone', function() {
381381
const recordsToDelete = {a: 'b', c: 'd'};
382382

383383
zone.createChange = function(options, callback) {
384-
assert.deepEqual(options.delete, [recordsToDelete]);
384+
assert.deepStrictEqual(options.delete, [recordsToDelete]);
385385
callback();
386386
};
387387

@@ -450,7 +450,7 @@ describe('Zone', function() {
450450

451451
it('should delete non-NS and non-SOA records', function(done) {
452452
zone.deleteRecords = function(recordsToDelete, callback) {
453-
assert.deepEqual(recordsToDelete, expectedRecordsToDelete);
453+
assert.deepStrictEqual(recordsToDelete, expectedRecordsToDelete);
454454
callback();
455455
};
456456

@@ -570,7 +570,7 @@ describe('Zone', function() {
570570
describe('getChanges', function() {
571571
it('should accept only a callback', function(done) {
572572
zone.request = function(reqOpts) {
573-
assert.deepEqual(reqOpts.qs, {});
573+
assert.deepStrictEqual(reqOpts.qs, {});
574574
done();
575575
};
576576

@@ -649,7 +649,7 @@ describe('Zone', function() {
649649
zone.getChanges({}, function(err, changes, nextQuery) {
650650
assert.ifError(err);
651651

652-
assert.deepEqual(nextQuery, expectedNextQuery);
652+
assert.deepStrictEqual(nextQuery, expectedNextQuery);
653653

654654
done();
655655
});
@@ -729,7 +729,7 @@ describe('Zone', function() {
729729
zone.getRecords({}, function(err, records, nextQuery) {
730730
assert.ifError(err);
731731

732-
assert.deepEqual(nextQuery, expectedNextQuery);
732+
assert.deepStrictEqual(nextQuery, expectedNextQuery);
733733

734734
done();
735735
});

0 commit comments

Comments
 (0)