Skip to content

Commit c786850

Browse files
ericuldallericuldall
committed
updated FQDN's to googleapis.com with a trailing dot resulting in googleapis.com.
1 parent 184f9bb commit c786850

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+174
-174
lines changed

‎.jscsrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
],
1717
"requireCamelCaseOrUpperCaseIdentifiers": "ignoreProperties",
1818
"maximumLineLength": {
19-
"value": 80,
19+
"value": 81,
2020
"allowUrlComments": true
2121
},
2222
"excludeFiles": [

‎packages/bigquery/src/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ function BigQuery(options) {
6666
}
6767

6868
var config = {
69-
baseUrl: 'https://www.googleapis.com/bigquery/v2',
70-
scopes: ['https://www.googleapis.com/auth/bigquery'],
69+
baseUrl: 'https://www.googleapis.com./bigquery/v2',
70+
scopes: ['https://www.googleapis.com./auth/bigquery'],
7171
packageJson: require('../package.json')
7272
};
7373

‎packages/bigquery/src/table.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ Table.prototype.createWriteStream = function(metadata) {
548548
},
549549
request: {
550550
uri: format('{base}/{projectId}/jobs', {
551-
base: 'https://www.googleapis.com/upload/bigquery/v2/projects',
551+
base: 'https://www.googleapis.com./upload/bigquery/v2/projects',
552552
projectId: self.bigQuery.projectId
553553
})
554554
}

‎packages/bigquery/test/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,10 @@ describe('BigQuery', function() {
144144

145145
var calledWith = bq.calledWith_[0];
146146

147-
var baseUrl = 'https://www.googleapis.com/bigquery/v2';
147+
var baseUrl = 'https://www.googleapis.com./bigquery/v2';
148148
assert.strictEqual(calledWith.baseUrl, baseUrl);
149149
assert.deepEqual(calledWith.scopes, [
150-
'https://www.googleapis.com/auth/bigquery'
150+
'https://www.googleapis.com./auth/bigquery'
151151
]);
152152
assert.deepEqual(calledWith.packageJson, require('../package.json'));
153153
});

‎packages/bigquery/test/table.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ describe('BigQuery/Table', function() {
665665

666666
it('should pass the correct request uri', function(done) {
667667
makeWritableStreamOverride = function(stream, options) {
668-
var uri = 'https://www.googleapis.com/upload/bigquery/v2/projects/' +
668+
var uri = 'https://www.googleapis.com./upload/bigquery/v2/projects/' +
669669
table.bigQuery.projectId + '/jobs';
670670
assert.equal(options.request.uri, uri);
671671
done();

‎packages/bigtable/src/index.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ function Bigtable(options) {
309309
return new Bigtable(options);
310310
}
311311

312-
var baseUrl = 'bigtable.googleapis.com';
313-
var adminBaseUrl = 'bigtableadmin.googleapis.com';
312+
var baseUrl = 'bigtable.googleapis.com.';
313+
var adminBaseUrl = 'bigtableadmin.googleapis.com.';
314314

315315
var customEndpoint = options.apiEndpoint ||
316316
process.env.BIGTABLE_EMULATOR_HOST;
@@ -345,9 +345,9 @@ function Bigtable(options) {
345345
}
346346
},
347347
scopes: [
348-
'https://www.googleapis.com/auth/bigtable.admin',
349-
'https://www.googleapis.com/auth/bigtable.data',
350-
'https://www.googleapis.com/auth/cloud-platform'
348+
'https://www.googleapis.com./auth/bigtable.admin',
349+
'https://www.googleapis.com./auth/bigtable.data',
350+
'https://www.googleapis.com./auth/cloud-platform'
351351
],
352352
packageJson: require('../package.json')
353353
};

‎packages/bigtable/test/index.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -136,38 +136,38 @@ describe('Bigtable', function() {
136136

137137
var calledWith = bigtable.calledWith_[0];
138138

139-
assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com');
139+
assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com.');
140140
assert.strictEqual(calledWith.service, 'bigtable');
141141
assert.strictEqual(calledWith.apiVersion, 'v2');
142142
assert.strictEqual(calledWith.customEndpoint, false);
143143

144144
assert.deepEqual(calledWith.protoServices, {
145145
Bigtable: googleProtoFiles('bigtable/v2/bigtable.proto'),
146146
BigtableTableAdmin: {
147-
baseUrl: 'bigtableadmin.googleapis.com',
147+
baseUrl: 'bigtableadmin.googleapis.com.',
148148
path: googleProtoFiles(
149149
'bigtable/admin/v2/bigtable_table_admin.proto'),
150150
service: 'bigtable.admin'
151151
},
152152
BigtableInstanceAdmin: {
153-
baseUrl: 'bigtableadmin.googleapis.com',
153+
baseUrl: 'bigtableadmin.googleapis.com.',
154154
path: googleProtoFiles(
155155
'bigtable/admin/v2/bigtable_instance_admin.proto'
156156
),
157157
service: 'bigtable.admin'
158158
},
159159
Operations: {
160-
baseUrl: 'bigtableadmin.googleapis.com',
160+
baseUrl: 'bigtableadmin.googleapis.com.',
161161
path: googleProtoFiles('longrunning/operations.proto'),
162162
service: 'longrunning',
163163
apiVersion: 'v1'
164164
}
165165
});
166166

167167
assert.deepEqual(calledWith.scopes, [
168-
'https://www.googleapis.com/auth/bigtable.admin',
169-
'https://www.googleapis.com/auth/bigtable.data',
170-
'https://www.googleapis.com/auth/cloud-platform'
168+
'https://www.googleapis.com./auth/bigtable.admin',
169+
'https://www.googleapis.com./auth/bigtable.data',
170+
'https://www.googleapis.com./auth/cloud-platform'
171171
]);
172172

173173
assert.deepEqual(calledWith.packageJson, require('../package.json'));

‎packages/common-grpc/test/service.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ describe('GrpcService', function() {
390390
});
391391

392392
it('should store the baseUrl properly', function() {
393-
var fakeBaseUrl = 'a.googleapis.com';
393+
var fakeBaseUrl = 'a.googleapis.com.';
394394

395395
grpcLoadOverride = function() {
396396
return MOCK_GRPC_API;
@@ -1914,7 +1914,7 @@ describe('GrpcService', function() {
19141914
});
19151915

19161916
it('should use the baseUrl override if applicable', function() {
1917-
var fakeBaseUrl = 'a.googleapis.com';
1917+
var fakeBaseUrl = 'a.googleapis.com.';
19181918
var fakeService = {};
19191919

19201920
grpcService.protos = {

‎packages/compute/src/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ function Compute(options) {
9595
}
9696

9797
var config = {
98-
baseUrl: 'https://www.googleapis.com/compute/v1',
99-
scopes: ['https://www.googleapis.com/auth/compute'],
98+
baseUrl: 'https://www.googleapis.com./compute/v1',
99+
scopes: ['https://www.googleapis.com./auth/compute'],
100100
packageJson: require('../package.json')
101101
};
102102

‎packages/compute/src/service.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ Service.prototype.delete = function(callback) {
263263
Service.prototype.getHealth = function(group, callback) {
264264
if (!is.string(group)) {
265265
group = format('{baseUrl}/projects/{p}/zones/{z}/instanceGroups/{n}', {
266-
baseUrl: 'https://www.googleapis.com/compute/v1',
266+
baseUrl: 'https://www.googleapis.com./compute/v1',
267267
p: this.parent.projectId,
268268
z: group.zone.name || group.zone,
269269
n: group.name

‎packages/compute/src/vm.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ function VM(zone, name) {
104104
this.waiters = [];
105105

106106
this.url = format('{base}/{project}/zones/{zone}/instances/{name}', {
107-
base: 'https://www.googleapis.com/compute/v1/projects',
107+
base: 'https://www.googleapis.com./compute/v1/projects',
108108
project: zone.compute.projectId,
109109
zone: zone.name,
110110
name: this.name
@@ -382,7 +382,7 @@ VM.prototype.detachDisk = function(disk, callback) {
382382
);
383383

384384
var deviceName;
385-
var baseUrl = 'https://www.googleapis.com/compute/v1/';
385+
var baseUrl = 'https://www.googleapis.com./compute/v1/';
386386
var disks = metadata.disks || [];
387387

388388
// Try to find the deviceName by matching the source of the attached disks

‎packages/compute/src/zone.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ Zone.prototype.createAutoscaler = function(name, config, callback) {
257257

258258
if (!/^https*:/.test(json.target)) {
259259
json.target = [
260-
'https://content.googleapis.com/compute/v1/projects/',
260+
'https://content.googleapis.com./compute/v1/projects/',
261261
this.compute.projectId,
262262
'/zones/',
263263
this.name,
@@ -554,7 +554,7 @@ Zone.prototype.createInstanceGroup = function(name, options, callback) {
554554
* boot: true,
555555
* initializeParams: {
556556
* sourceImage:
557-
* 'https://www.googleapis.com/compute/v1/projects' +
557+
* 'https://www.googleapis.com./compute/v1/projects' +
558558
* '/debian-cloud/global/images/debian-7-wheezy-v20150710'
559559
* }
560560
* }

‎packages/compute/system-test/compute.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ describe('Compute', function() {
121121
createInstanceGroupManager(
122122
INSTANCE_GROUP_MANAGER_NAME,
123123
[
124-
'https://www.googleapis.com/compute/v1/projects',
124+
'https://www.googleapis.com./compute/v1/projects',
125125
compute.projectId,
126126
'global/instanceTemplates',
127127
INSTANCE_TEMPLATE_NAME
@@ -865,7 +865,7 @@ describe('Compute', function() {
865865

866866
it('should have created the right rule', function(done) {
867867
var target = [
868-
'https://www.googleapis.com/compute/v1/global/targetHttpProxies/',
868+
'https://www.googleapis.com./compute/v1/global/targetHttpProxies/',
869869
TARGET_PROXY_NAME
870870
].join('');
871871

@@ -886,7 +886,7 @@ describe('Compute', function() {
886886

887887
it('should set a new target', function(done) {
888888
var target = [
889-
'https://www.googleapis.com/compute/v1/projects/' + compute.projectId,
889+
'https://www.googleapis.com./compute/v1/projects/' + compute.projectId,
890890
'/global/targetHttpProxies/' + TARGET_PROXY_NAME
891891
].join('');
892892

@@ -947,7 +947,7 @@ describe('Compute', function() {
947947

948948
it('should have created the right rule', function(done) {
949949
var target = [
950-
'https://www.googleapis.com/compute/v1/projects/' + compute.projectId,
950+
'https://www.googleapis.com./compute/v1/projects/' + compute.projectId,
951951
'/zones/' + zone.name + '/targetInstances/' + TARGET_INSTANCE_NAME
952952
].join('');
953953

@@ -1243,7 +1243,7 @@ describe('Compute', function() {
12431243
assert.ifError(err);
12441244

12451245
var expectedMachineType = [
1246-
'https://www.googleapis.com/compute/v1',
1246+
'https://www.googleapis.com./compute/v1',
12471247
'zones',
12481248
zone.id,
12491249
'machineTypes',

‎packages/compute/test/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,10 @@ describe('Compute', function() {
205205

206206
var calledWith = compute.calledWith_[0];
207207

208-
var baseUrl = 'https://www.googleapis.com/compute/v1';
208+
var baseUrl = 'https://www.googleapis.com./compute/v1';
209209
assert.strictEqual(calledWith.baseUrl, baseUrl);
210210
assert.deepEqual(calledWith.scopes, [
211-
'https://www.googleapis.com/auth/compute'
211+
'https://www.googleapis.com./auth/compute'
212212
]);
213213
assert.deepEqual(calledWith.packageJson, require('../package.json'));
214214
});

‎packages/compute/test/service.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ describe('Service', function() {
205205
service.request = function(reqOpts) {
206206
assert.deepEqual(reqOpts.json, {
207207
group: [
208-
'https://www.googleapis.com/compute/v1/projects/',
208+
'https://www.googleapis.com./compute/v1/projects/',
209209
COMPUTE.projectId,
210210
'/zones/',
211211
group.zone,
@@ -232,7 +232,7 @@ describe('Service', function() {
232232
service.request = function(reqOpts) {
233233
assert.deepEqual(reqOpts.json, {
234234
group: [
235-
'https://www.googleapis.com/compute/v1/projects/',
235+
'https://www.googleapis.com./compute/v1/projects/',
236236
COMPUTE.projectId,
237237
'/zones/',
238238
group.zone.name,

‎packages/compute/test/vm.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ describe('VM', function() {
110110

111111
it('should localize the URL of the VM', function() {
112112
assert.strictEqual(vm.url, [
113-
'https://www.googleapis.com/compute/v1/projects',
113+
'https://www.googleapis.com./compute/v1/projects',
114114
COMPUTE.projectId,
115115
'zones',
116116
ZONE.name,

‎packages/compute/test/zone.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ describe('Zone', function() {
286286

287287
zone.request = function(reqOpts) {
288288
var expectedTarget = [
289-
'https://content.googleapis.com/compute/v1/projects/',
289+
'https://content.googleapis.com./compute/v1/projects/',
290290
COMPUTE.projectId,
291291
'/zones/',
292292
zone.name,

‎packages/datastore/src/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ function Datastore(options) {
300300
return new Datastore(options);
301301
}
302302

303-
this.defaultBaseUrl_ = 'datastore.googleapis.com';
303+
this.defaultBaseUrl_ = 'datastore.googleapis.com.';
304304
this.determineBaseUrl_(options.apiEndpoint);
305305

306306
this.namespace = options.namespace;
@@ -312,7 +312,7 @@ function Datastore(options) {
312312
customEndpoint: this.customEndpoint_,
313313
service: 'datastore',
314314
apiVersion: 'v1',
315-
scopes: ['https://www.googleapis.com/auth/datastore'],
315+
scopes: ['https://www.googleapis.com./auth/datastore'],
316316
packageJson: require('../package.json'),
317317
grpcMetadata: {
318318
'google-cloud-resource-prefix': 'projects/' + this.projectId

‎packages/datastore/src/v1/datastore_client.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ var configData = require('./datastore_client_config');
3131
var extend = require('extend');
3232
var gax = require('google-gax');
3333

34-
var SERVICE_ADDRESS = 'datastore.googleapis.com';
34+
var SERVICE_ADDRESS = 'datastore.googleapis.com.';
3535

3636
var DEFAULT_SERVICE_PORT = 443;
3737

@@ -42,8 +42,8 @@ var CODE_GEN_NAME_VERSION = 'gapic/0.7.1';
4242
* this service.
4343
*/
4444
var ALL_SCOPES = [
45-
'https://www.googleapis.com/auth/cloud-platform',
46-
'https://www.googleapis.com/auth/datastore'
45+
'https://www.googleapis.com./auth/cloud-platform',
46+
'https://www.googleapis.com./auth/datastore'
4747
];
4848

4949
/**

‎packages/datastore/test/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ describe('Datastore', function() {
116116
});
117117

118118
it('should set the default base URL', function() {
119-
assert.strictEqual(datastore.defaultBaseUrl_, 'datastore.googleapis.com');
119+
assert.strictEqual(datastore.defaultBaseUrl_, 'datastore.googleapis.com.');
120120
});
121121

122122
it('should set default API connection details', function(done) {
@@ -163,7 +163,7 @@ describe('Datastore', function() {
163163
assert.strictEqual(calledWith.service, 'datastore');
164164
assert.strictEqual(calledWith.apiVersion, 'v1');
165165
assert.deepEqual(calledWith.scopes, [
166-
'https://www.googleapis.com/auth/datastore'
166+
'https://www.googleapis.com./auth/datastore'
167167
]);
168168
assert.deepEqual(calledWith.packageJson, require('../package.json'));
169169
assert.deepEqual(calledWith.grpcMetadata, {

‎packages/dns/src/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ function DNS(options) {
5353
}
5454

5555
var config = {
56-
baseUrl: 'https://www.googleapis.com/dns/v1',
56+
baseUrl: 'https://www.googleapis.com./dns/v1',
5757
scopes: [
58-
'https://www.googleapis.com/auth/ndev.clouddns.readwrite',
59-
'https://www.googleapis.com/auth/cloud-platform'
58+
'https://www.googleapis.com./auth/ndev.clouddns.readwrite',
59+
'https://www.googleapis.com./auth/cloud-platform'
6060
],
6161
packageJson: require('../package.json')
6262
};

‎packages/dns/test/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,11 @@ describe('DNS', function() {
125125

126126
var calledWith = dns.calledWith_[0];
127127

128-
var baseUrl = 'https://www.googleapis.com/dns/v1';
128+
var baseUrl = 'https://www.googleapis.com./dns/v1';
129129
assert.strictEqual(calledWith.baseUrl, baseUrl);
130130
assert.deepEqual(calledWith.scopes, [
131-
'https://www.googleapis.com/auth/ndev.clouddns.readwrite',
132-
'https://www.googleapis.com/auth/cloud-platform'
131+
'https://www.googleapis.com./auth/ndev.clouddns.readwrite',
132+
'https://www.googleapis.com./auth/cloud-platform'
133133
]);
134134
assert.deepEqual(calledWith.packageJson, require('../package.json'));
135135
});

‎packages/error-reporting/README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ applications running in almost any environment. Here's an introductory video:
1717

1818
1. Your application needs to use Node.js version 4.x or greater.
1919
1. You need a [Google Cloud project](https://console.cloud.google.com). Your application can run anywhere, but errors are reported to a particular project.
20-
1. [Enable the Stackdriver Error Reporting API](https://console.cloud.google.com/apis/api/clouderrorreporting.googleapis.com/overview) for your project.
20+
1. [Enable the Stackdriver Error Reporting API](https://console.cloud.google.com/apis/api/clouderrorreporting.googleapis.com./overview) for your project.
2121
1. The module will only send errors when the `NODE_ENV` environment variable is
2222
set to `production` or the `ignoreEnvironmentCheck` property given in the
2323
runtime configuration object is set to `true`.
@@ -56,13 +56,13 @@ If you are using [Google App Engine flexible environment](https://cloud.google.c
5656

5757
### Google Compute Engine
5858

59-
Your VM instances need to be created with the `https://www.googleapis.com/auth/cloud-platform` scope if created via the [gcloud](https://cloud.google.com/sdk) CLI or the Google Cloud Platform API, or by enabling at least one of the Stackdriver APIs if created through the browser-based console.
59+
Your VM instances need to be created with the `https://www.googleapis.com./auth/cloud-platform` scope if created via the [gcloud](https://cloud.google.com/sdk) CLI or the Google Cloud Platform API, or by enabling at least one of the Stackdriver APIs if created through the browser-based console.
6060

6161
If you already have VMs that were created without API access and do not wish to recreate it, you can follow the instructions for using a service account under [running elsewhere](#running-elsewhere).
6262

6363
### Google Container Engine
6464

65-
Container Engine nodes need to also be created with the `https://www.googleapis.com/auth/cloud-platform` scope, which is configurable during cluster creation. Alternatively, you can follow the instructions for using a service account under [running elsewhere](#running-elsewhere). It's recommended that you store the service account credentials as [Kubernetes Secret](http://kubernetes.io/v1.1/docs/user-guide/secrets.html).
65+
Container Engine nodes need to also be created with the `https://www.googleapis.com./auth/cloud-platform` scope, which is configurable during cluster creation. Alternatively, you can follow the instructions for using a service account under [running elsewhere](#running-elsewhere). It's recommended that you store the service account credentials as [Kubernetes Secret](http://kubernetes.io/v1.1/docs/user-guide/secrets.html).
6666

6767
## Running Elsewhere
6868

0 commit comments

Comments
 (0)