fix: better support for fallback mode (#543)

gcf-owl-bot[bot] · web-flow · commit ae9f928a1d2a · 2022-08-23T00:12:19.000Z
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
diff --git a/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.delete_posix_account.js b/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.delete_posix_account.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1_generated_OsLoginService_DeletePosixAccount_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.delete_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.delete_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1_generated_OsLoginService_DeleteSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.get_login_profile.js b/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.get_login_profile.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1_generated_OsLoginService_GetLoginProfile_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.get_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.get_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1_generated_OsLoginService_GetSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.import_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.import_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(parent) {
   // [START oslogin_v1_generated_OsLoginService_ImportSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.update_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1/os_login_service.update_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(name, sshPublicKey) {
   // [START oslogin_v1_generated_OsLoginService_UpdateSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1/snippet_metadata.google.cloud.oslogin.v1.json b/packages/google-cloud-oslogin/samples/generated/v1/snippet_metadata.google.cloud.oslogin.v1.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -62,7 +62,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -102,7 +102,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 58,
+                    "end": 61,
                     "type": "FULL"
                 }
             ],
@@ -150,7 +150,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -190,7 +190,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 58,
+                    "end": 61,
                     "type": "FULL"
                 }
             ],
@@ -238,7 +238,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 61,
+                    "end": 64,
                     "type": "FULL"
                 }
             ],
diff --git a/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.delete_posix_account.js b/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.delete_posix_account.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1beta_generated_OsLoginService_DeletePosixAccount_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.delete_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.delete_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1beta_generated_OsLoginService_DeleteSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.get_login_profile.js b/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.get_login_profile.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1beta_generated_OsLoginService_GetLoginProfile_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.get_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.get_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START oslogin_v1beta_generated_OsLoginService_GetSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.import_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.import_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(sshPublicKey) {
   // [START oslogin_v1beta_generated_OsLoginService_ImportSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.update_ssh_public_key.js b/packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.update_ssh_public_key.js
@@ -23,6 +23,9 @@
 function main(name, sshPublicKey) {
   // [START oslogin_v1beta_generated_OsLoginService_UpdateSshPublicKey_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-oslogin/samples/generated/v1beta/snippet_metadata.google.cloud.oslogin.v1beta.json b/packages/google-cloud-oslogin/samples/generated/v1beta/snippet_metadata.google.cloud.oslogin.v1beta.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -62,7 +62,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -102,7 +102,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 58,
+                    "end": 61,
                     "type": "FULL"
                 }
             ],
@@ -150,7 +150,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -190,7 +190,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 58,
+                    "end": 61,
                     "type": "FULL"
                 }
             ],
@@ -238,7 +238,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 61,
+                    "end": 64,
                     "type": "FULL"
                 }
             ],
diff --git a/packages/google-cloud-oslogin/src/v1/os_login_service_client.ts b/packages/google-cloud-oslogin/src/v1/os_login_service_client.ts
@@ -242,7 +242,8 @@ export class OsLoginServiceClient {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
diff --git a/packages/google-cloud-oslogin/src/v1beta/os_login_service_client.ts b/packages/google-cloud-oslogin/src/v1beta/os_login_service_client.ts
@@ -242,7 +242,8 @@ export class OsLoginServiceClient {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
diff --git a/packages/google-cloud-oslogin/test/gapic_os_login_service_v1.ts b/packages/google-cloud-oslogin/test/gapic_os_login_service_v1.ts
diff --git a/packages/google-cloud-oslogin/test/gapic_os_login_service_v1beta.ts b/packages/google-cloud-oslogin/test/gapic_os_login_service_v1beta.ts

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`"segments": [`
`23`	`23`	`{`
`24`	`24`	`"start": 25,`
`25`		`- "end": 52,`
	`25`	`+ "end": 55,`
`26`	`26`	`"type": "FULL"`
`27`	`27`	`}`
`28`	`28`	`],`
`@@ -62,7 +62,7 @@`
`62`	`62`	`"segments": [`
`63`	`63`	`{`
`64`	`64`	`"start": 25,`
`65`		`- "end": 52,`
	`65`	`+ "end": 55,`
`66`	`66`	`"type": "FULL"`
`67`	`67`	`}`
`68`	`68`	`],`
`@@ -102,7 +102,7 @@`
`102`	`102`	`"segments": [`
`103`	`103`	`{`
`104`	`104`	`"start": 25,`
`105`		`- "end": 58,`
	`105`	`+ "end": 61,`
`106`	`106`	`"type": "FULL"`
`107`	`107`	`}`
`108`	`108`	`],`
`@@ -150,7 +150,7 @@`
`150`	`150`	`"segments": [`
`151`	`151`	`{`
`152`	`152`	`"start": 25,`
`153`		`- "end": 52,`
	`153`	`+ "end": 55,`
`154`	`154`	`"type": "FULL"`
`155`	`155`	`}`
`156`	`156`	`],`
`@@ -190,7 +190,7 @@`
`190`	`190`	`"segments": [`
`191`	`191`	`{`
`192`	`192`	`"start": 25,`
`193`		`- "end": 58,`
	`193`	`+ "end": 61,`
`194`	`194`	`"type": "FULL"`
`195`	`195`	`}`
`196`	`196`	`],`
`@@ -238,7 +238,7 @@`
`238`	`238`	`"segments": [`
`239`	`239`	`{`
`240`	`240`	`"start": 25,`
`241`		`- "end": 61,`
	`241`	`+ "end": 64,`
`242`	`242`	`"type": "FULL"`
`243`	`243`	`}`
`244`	`244`	`],`