Skip to content

Commit aa8a61f

Browse files
docs: update OPTIONAL annotations for some fields (#686)
PiperOrigin-RevId: 333132625 Source-Author: Google APIs <[email protected]> Source-Date: Tue Sep 22 12:14:18 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 470d84e263c833af5280753b8e4188432b8d5b06 Source-Link: googleapis/googleapis@470d84e
1 parent f9bb798 commit aa8a61f

File tree

5 files changed

+28
-30
lines changed

5 files changed

+28
-30
lines changed

packages/google-cloud-dialogflow/protos/google/cloud/dialogflow/v2beta1/knowledge_base.proto

+5-5
Original file line numberDiff line numberDiff line change
@@ -156,12 +156,12 @@ message ListKnowledgeBasesRequest {
156156
}
157157
];
158158

159-
// Optional. The maximum number of items to return in a single page. By
159+
// The maximum number of items to return in a single page. By
160160
// default 10 and at most 100.
161-
int32 page_size = 2 [(google.api.field_behavior) = OPTIONAL];
161+
int32 page_size = 2;
162162

163-
// Optional. The next_page_token value returned from a previous list request.
164-
string page_token = 3 [(google.api.field_behavior) = OPTIONAL];
163+
// The next_page_token value returned from a previous list request.
164+
string page_token = 3;
165165
}
166166

167167
// Response message for [KnowledgeBases.ListKnowledgeBases][google.cloud.dialogflow.v2beta1.KnowledgeBases.ListKnowledgeBases].
@@ -214,7 +214,7 @@ message DeleteKnowledgeBaseRequest {
214214

215215
// Optional. Force deletes the knowledge base. When set to true, any documents
216216
// in the knowledge base are also deleted.
217-
bool force = 2;
217+
bool force = 2 [(google.api.field_behavior) = OPTIONAL];
218218
}
219219

220220
// Request message for [KnowledgeBases.UpdateKnowledgeBase][google.cloud.dialogflow.v2beta1.KnowledgeBases.UpdateKnowledgeBase].

packages/google-cloud-dialogflow/protos/google/cloud/dialogflow/v2beta1/session.proto

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import "google/api/resource.proto";
2323
import "google/cloud/dialogflow/v2beta1/agent.proto";
2424
import "google/cloud/dialogflow/v2beta1/audio_config.proto";
2525
import "google/cloud/dialogflow/v2beta1/context.proto";
26+
import "google/cloud/dialogflow/v2beta1/gcs.proto";
2627
import "google/cloud/dialogflow/v2beta1/intent.proto";
2728
import "google/cloud/dialogflow/v2beta1/session_entity_type.proto";
2829
import "google/protobuf/duration.proto";

packages/google-cloud-dialogflow/protos/protos.json

+6-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-dialogflow/src/v2beta1/knowledge_bases_client.ts

+13-13
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ export class KnowledgeBasesClient {
599599
* @param {string} request.name
600600
* Required. The name of the knowledge base to delete.
601601
* Format: `projects/<Project ID>/knowledgeBases/<Knowledge Base ID>`.
602-
* @param {boolean} request.force
602+
* @param {boolean} [request.force]
603603
* Optional. Force deletes the knowledge base. When set to true, any documents
604604
* in the knowledge base are also deleted.
605605
* @param {object} [options]
@@ -799,11 +799,11 @@ export class KnowledgeBasesClient {
799799
* @param {string} request.parent
800800
* Required. The project to list of knowledge bases for.
801801
* Format: `projects/<Project ID>`.
802-
* @param {number} [request.pageSize]
803-
* Optional. The maximum number of items to return in a single page. By
802+
* @param {number} request.pageSize
803+
* The maximum number of items to return in a single page. By
804804
* default 10 and at most 100.
805-
* @param {string} [request.pageToken]
806-
* Optional. The next_page_token value returned from a previous list request.
805+
* @param {string} request.pageToken
806+
* The next_page_token value returned from a previous list request.
807807
* @param {object} [options]
808808
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
809809
* @returns {Promise} - The promise which resolves to an array.
@@ -885,11 +885,11 @@ export class KnowledgeBasesClient {
885885
* @param {string} request.parent
886886
* Required. The project to list of knowledge bases for.
887887
* Format: `projects/<Project ID>`.
888-
* @param {number} [request.pageSize]
889-
* Optional. The maximum number of items to return in a single page. By
888+
* @param {number} request.pageSize
889+
* The maximum number of items to return in a single page. By
890890
* default 10 and at most 100.
891-
* @param {string} [request.pageToken]
892-
* Optional. The next_page_token value returned from a previous list request.
891+
* @param {string} request.pageToken
892+
* The next_page_token value returned from a previous list request.
893893
* @param {object} [options]
894894
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
895895
* @returns {Stream}
@@ -927,11 +927,11 @@ export class KnowledgeBasesClient {
927927
* @param {string} request.parent
928928
* Required. The project to list of knowledge bases for.
929929
* Format: `projects/<Project ID>`.
930-
* @param {number} [request.pageSize]
931-
* Optional. The maximum number of items to return in a single page. By
930+
* @param {number} request.pageSize
931+
* The maximum number of items to return in a single page. By
932932
* default 10 and at most 100.
933-
* @param {string} [request.pageToken]
934-
* Optional. The next_page_token value returned from a previous list request.
933+
* @param {string} request.pageToken
934+
* The next_page_token value returned from a previous list request.
935935
* @param {object} [options]
936936
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
937937
* @returns {Object}

packages/google-cloud-dialogflow/synth.metadata

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/nodejs-dialogflow.git",
7-
"sha": "3cba5aa9f4cf11f586b114c2a03757a3f7409dcf"
7+
"sha": "fc7565994a009a64c703b3da2a36a0e946e96a0f"
88
}
99
},
1010
{
1111
"git": {
1212
"name": "googleapis",
1313
"remote": "https://github.com/googleapis/googleapis.git",
14-
"sha": "791be5a40033c18034afed50232daad6bdc8cf3e",
15-
"internalRef": "331627223"
14+
"sha": "470d84e263c833af5280753b8e4188432b8d5b06",
15+
"internalRef": "333132625"
1616
}
1717
},
1818
{

0 commit comments

Comments
 (0)