Skip to content

Commit aa5c254

Browse files
stephenpluspluscallmehiphop
authored andcommitted
all modules: ensure all User-Agents are set (#1568)
1 parent ca76a24 commit aa5c254

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

packages/google-cloud-resourcemanager/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"resource"
5151
],
5252
"dependencies": {
53-
"@google-cloud/common": "^0.1.0",
53+
"@google-cloud/common": "^0.5.0",
5454
"extend": "^3.0.0",
5555
"is": "^3.0.1"
5656
},

packages/google-cloud-resourcemanager/src/index.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ var util = require('util');
3131
*/
3232
var Project = require('./project.js');
3333

34-
var PKG = require('../package.json');
35-
3634
/**
3735
* <p class="notice">
3836
* **This is a Beta release of Cloud Resource Manager.** This feature is not
@@ -69,7 +67,7 @@ function Resource(options) {
6967
baseUrl: 'https://cloudresourcemanager.googleapis.com/v1beta1',
7068
scopes: ['https://www.googleapis.com/auth/cloud-platform'],
7169
projectIdRequired: false,
72-
userAgent: PKG.name + '/' + PKG.version
70+
packageJson: require('../package.json')
7371
};
7472

7573
common.Service.call(this, config, options);

packages/google-cloud-resourcemanager/test/index.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ var proxyquire = require('proxyquire');
2424
var Service = require('@google-cloud/common').Service;
2525
var util = require('@google-cloud/common').util;
2626

27-
var PKG = require('../package.json');
28-
2927
function FakeProject() {
3028
this.calledWith_ = [].slice.call(arguments);
3129
}
@@ -126,7 +124,7 @@ describe('Resource', function() {
126124
'https://www.googleapis.com/auth/cloud-platform'
127125
]);
128126
assert.strictEqual(resource.projectIdRequired, false);
129-
assert.strictEqual(calledWith.userAgent, PKG.name + '/' + PKG.version);
127+
assert.deepEqual(calledWith.packageJson, require('../package.json'));
130128
});
131129
});
132130

0 commit comments

Comments
 (0)