Merge pull request #907 from stephenplusplus/spp--util-unauthorized-api-requests

core: emit auto-auth errors

Author: stephenplusplus

lib/common/util.js

@@ -337,13 +337,7 @@ function makeAuthenticatedRequestFactory(config) {
     }
 
     function onAuthenticated(err, authenticatedReqOpts) {
-      // google-auth-library returns a "Could not load..." error if it can't get
-      // an access token. However, it's possible an API request doesn't need to
-      // be authenticated, e.g. when downloading a file from a public bucket. We
-      // consider this error a warning, and allow the request to go through
-      // without authentication, relying on the upstream API to return an error
-      // the user would find more helpful, should one occur.
-      if (err && err.message.indexOf('Could not load') === -1) {
+      if (err) {
         if (stream) {
           stream.destroy(err);
         } else {

test/common/util.js

@@ -535,26 +535,6 @@ describe('common/util', function() {
           };
         });
 
-        it('should not care about "Could not load" errors', function(done) {
-          var error = new Error('Could not load');
-
-          utilOverrides.decorateRequest = function() {};
-
-          authClient.authorizeRequest = function(rOpts, callback) {
-            setImmediate(function() {
-              callback(error);
-            });
-          };
-
-          var makeAuthenticatedRequest = util.makeAuthenticatedRequestFactory();
-          makeAuthenticatedRequest({}, {
-            onAuthenticated: function(err) {
-              assert.strictEqual(err, null);
-              done();
-            }
-          });
-        });
-
         it('should invoke the callback with error', function(done) {
           var makeAuthenticatedRequest = util.makeAuthenticatedRequestFactory();
           makeAuthenticatedRequest({}, function(err) {