Skip to content

Commit 952b787

Browse files
jkwluiJustinBeckwith
authored andcommitted
chore: assert.deelEqual => assert.deepStrictEqual (#81)
1 parent 3fb4cb5 commit 952b787

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

packages/google-cloud-translate/system-test/translate.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ describe('translate', function() {
129129
return language.code === 'en';
130130
})[0];
131131

132-
assert.deepEqual(englishResult, {
132+
assert.deepStrictEqual(englishResult, {
133133
code: 'en',
134134
name: 'English',
135135
});
@@ -146,7 +146,7 @@ describe('translate', function() {
146146
return language.code === 'en';
147147
})[0];
148148

149-
assert.deepEqual(englishResult, {
149+
assert.deepStrictEqual(englishResult, {
150150
code: 'en',
151151
name: 'inglés',
152152
});

packages/google-cloud-translate/test/index.ts

+17-17
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,10 @@ describe('Translate', () => {
8383
'https://translation.googleapis.com/language/translate/v2';
8484

8585
assert.strictEqual(calledWith.baseUrl, baseUrl);
86-
assert.deepEqual(calledWith.scopes, [
86+
assert.deepStrictEqual(calledWith.scopes, [
8787
'https://www.googleapis.com/auth/cloud-platform',
8888
]);
89-
assert.deepEqual(calledWith.packageJson, pkgJson);
89+
assert.deepStrictEqual(calledWith.packageJson, pkgJson);
9090
assert.strictEqual(calledWith.projectIdRequired, false);
9191
});
9292

@@ -149,7 +149,7 @@ describe('Translate', () => {
149149
translate.request = reqOpts => {
150150
assert.strictEqual(reqOpts.uri, '/detect');
151151
assert.strictEqual(reqOpts.method, 'POST');
152-
assert.deepEqual(reqOpts.json, {q: [INPUT]});
152+
assert.deepStrictEqual(reqOpts.json, {q: [INPUT]});
153153
done();
154154
};
155155

@@ -208,27 +208,27 @@ describe('Translate', () => {
208208
it('should execute callback with results & API response', done => {
209209
translate.detect(INPUT, (err, results, apiResponse_) => {
210210
assert.ifError(err);
211-
assert.deepEqual(results, expectedResults);
211+
assert.deepStrictEqual(results, expectedResults);
212212
assert.strictEqual(apiResponse_, apiResponse);
213-
assert.deepEqual(apiResponse_, originalApiResponse);
213+
assert.deepStrictEqual(apiResponse_, originalApiResponse);
214214
done();
215215
});
216216
});
217217

218218
it('should execute callback with multiple results', done => {
219219
translate.detect([INPUT, INPUT], (err, results) => {
220220
assert.ifError(err);
221-
assert.deepEqual(results, [expectedResults]);
221+
assert.deepStrictEqual(results, [expectedResults]);
222222
done();
223223
});
224224
});
225225

226226
it('should return an array if input was an array', done => {
227227
translate.detect([INPUT], (err, results, apiResponse_) => {
228228
assert.ifError(err);
229-
assert.deepEqual(results, [expectedResults]);
229+
assert.deepStrictEqual(results, [expectedResults]);
230230
assert.strictEqual(apiResponse_, apiResponse);
231-
assert.deepEqual(apiResponse_, originalApiResponse);
231+
assert.deepStrictEqual(apiResponse_, originalApiResponse);
232232
done();
233233
});
234234
});
@@ -239,7 +239,7 @@ describe('Translate', () => {
239239
it('should make the correct API request', done => {
240240
translate.request = reqOpts => {
241241
assert.strictEqual(reqOpts.uri, '/languages');
242-
assert.deepEqual(reqOpts.qs, {
242+
assert.deepStrictEqual(reqOpts.qs, {
243243
target: 'en',
244244
});
245245
done();
@@ -251,7 +251,7 @@ describe('Translate', () => {
251251
it('should make the correct API request with target', done => {
252252
translate.request = reqOpts => {
253253
assert.strictEqual(reqOpts.uri, '/languages');
254-
assert.deepEqual(reqOpts.qs, {
254+
assert.deepStrictEqual(reqOpts.qs, {
255255
target: 'es',
256256
});
257257
done();
@@ -316,7 +316,7 @@ describe('Translate', () => {
316316
it('should exec callback with languages', done => {
317317
translate.getLanguages((err, languages, apiResponse_) => {
318318
assert.ifError(err);
319-
assert.deepEqual(languages, expectedResults);
319+
assert.deepStrictEqual(languages, expectedResults);
320320
assert.strictEqual(apiResponse_, apiResponse);
321321
done();
322322
});
@@ -422,7 +422,7 @@ describe('Translate', () => {
422422
translate.request = reqOpts => {
423423
assert.strictEqual(reqOpts.uri, '');
424424
assert.strictEqual(reqOpts.method, 'POST');
425-
assert.deepEqual(reqOpts.json, {
425+
assert.deepStrictEqual(reqOpts.json, {
426426
q: [INPUT],
427427
format: 'text',
428428
source: SOURCE_LANG_CODE,
@@ -478,7 +478,7 @@ describe('Translate', () => {
478478
it('should execute callback with results & API response', done => {
479479
translate.translate(INPUT, OPTIONS, (err, translations, resp) => {
480480
assert.ifError(err);
481-
assert.deepEqual(translations, expectedResults);
481+
assert.deepStrictEqual(translations, expectedResults);
482482
assert.strictEqual(resp, apiResponse);
483483
done();
484484
});
@@ -488,15 +488,15 @@ describe('Translate', () => {
488488
const input = [INPUT, INPUT];
489489
translate.translate(input, OPTIONS, (err, translations) => {
490490
assert.ifError(err);
491-
assert.deepEqual(translations, [expectedResults]);
491+
assert.deepStrictEqual(translations, [expectedResults]);
492492
done();
493493
});
494494
});
495495

496496
it('should return an array if input was an array', done => {
497497
translate.translate([INPUT], OPTIONS, (err, translations) => {
498498
assert.ifError(err);
499-
assert.deepEqual(translations, [expectedResults]);
499+
assert.deepStrictEqual(translations, [expectedResults]);
500500
done();
501501
});
502502
});
@@ -548,7 +548,7 @@ describe('Translate', () => {
548548
const getUserAgentFn = fakeUtil.getUserAgentFromPackageJson;
549549
fakeUtil.getUserAgentFromPackageJson = (packageJson) => {
550550
fakeUtil.getUserAgentFromPackageJson = getUserAgentFn;
551-
assert.deepEqual(packageJson, pkgJson);
551+
assert.deepStrictEqual(packageJson, pkgJson);
552552
return userAgent;
553553
};
554554

@@ -574,7 +574,7 @@ describe('Translate', () => {
574574
expectedReqOpts.uri = translate.baseUrl + reqOpts.uri;
575575

576576
makeRequestOverride = (reqOpts, options, callback) => {
577-
assert.deepEqual(reqOpts, expectedReqOpts);
577+
assert.deepStrictEqual(reqOpts, expectedReqOpts);
578578
assert.strictEqual(options, translate.options);
579579
callback(); // done()
580580
};

0 commit comments

Comments
 (0)