fix: better support for fallback mode (#19)

gcf-owl-bot[bot] · web-flow · commit 90a84031bbed · 2022-08-23T00:08:27.000Z
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
diff --git a/packages/google-cloud-run/samples/generated/v2/revisions.delete_revision.js b/packages/google-cloud-run/samples/generated/v2/revisions.delete_revision.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START run_v2_generated_Revisions_DeleteRevision_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/revisions.get_revision.js b/packages/google-cloud-run/samples/generated/v2/revisions.get_revision.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START run_v2_generated_Revisions_GetRevision_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/revisions.list_revisions.js b/packages/google-cloud-run/samples/generated/v2/revisions.list_revisions.js
@@ -23,6 +23,9 @@
 function main(parent) {
   // [START run_v2_generated_Revisions_ListRevisions_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.create_service.js b/packages/google-cloud-run/samples/generated/v2/services.create_service.js
@@ -23,6 +23,9 @@
 function main(parent, service, serviceId) {
   // [START run_v2_generated_Services_CreateService_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.delete_service.js b/packages/google-cloud-run/samples/generated/v2/services.delete_service.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START run_v2_generated_Services_DeleteService_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.get_iam_policy.js b/packages/google-cloud-run/samples/generated/v2/services.get_iam_policy.js
@@ -23,6 +23,9 @@
 function main(resource) {
   // [START run_v2_generated_Services_GetIamPolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.get_service.js b/packages/google-cloud-run/samples/generated/v2/services.get_service.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START run_v2_generated_Services_GetService_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.list_services.js b/packages/google-cloud-run/samples/generated/v2/services.list_services.js
@@ -23,6 +23,9 @@
 function main(parent) {
   // [START run_v2_generated_Services_ListServices_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.set_iam_policy.js b/packages/google-cloud-run/samples/generated/v2/services.set_iam_policy.js
@@ -23,6 +23,9 @@
 function main(resource, policy) {
   // [START run_v2_generated_Services_SetIamPolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.test_iam_permissions.js b/packages/google-cloud-run/samples/generated/v2/services.test_iam_permissions.js
@@ -23,6 +23,9 @@
 function main(resource, permissions) {
   // [START run_v2_generated_Services_TestIamPermissions_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/services.update_service.js b/packages/google-cloud-run/samples/generated/v2/services.update_service.js
@@ -23,6 +23,9 @@
 function main(service) {
   // [START run_v2_generated_Services_UpdateService_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/packages/google-cloud-run/samples/generated/v2/snippet_metadata.google.cloud.run.v2.json b/packages/google-cloud-run/samples/generated/v2/snippet_metadata.google.cloud.run.v2.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -62,7 +62,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 68,
+                    "end": 71,
                     "type": "FULL"
                 }
             ],
@@ -114,7 +114,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 63,
+                    "end": 66,
                     "type": "FULL"
                 }
             ],
@@ -162,7 +162,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 68,
+                    "end": 71,
                     "type": "FULL"
                 }
             ],
@@ -214,7 +214,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -254,7 +254,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 67,
+                    "end": 70,
                     "type": "FULL"
                 }
             ],
@@ -306,7 +306,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 62,
+                    "end": 65,
                     "type": "FULL"
                 }
             ],
@@ -354,7 +354,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 62,
+                    "end": 65,
                     "type": "FULL"
                 }
             ],
@@ -402,7 +402,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 56,
+                    "end": 59,
                     "type": "FULL"
                 }
             ],
@@ -446,7 +446,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 66,
+                    "end": 69,
                     "type": "FULL"
                 }
             ],
@@ -494,7 +494,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 59,
+                    "end": 62,
                     "type": "FULL"
                 }
             ],
diff --git a/packages/google-cloud-run/src/v2/revisions_client.ts b/packages/google-cloud-run/src/v2/revisions_client.ts
@@ -30,7 +30,6 @@ import {
 } from 'google-gax';
 
 import {Transform} from 'stream';
-import {RequestType} from 'google-gax/build/src/apitypes';
 import * as protos from '../../protos/protos';
 import jsonProtos = require('../../protos/protos.json');
 /**
@@ -313,7 +312,8 @@ export class RevisionsClient {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
@@ -621,7 +621,7 @@ export class RevisionsClient {
     const decodeOperation = new gax.Operation(
       operation,
       this.descriptors.longrunning.deleteRevision,
-      gax.createDefaultBackoffSettings()
+      this._gaxModule.createDefaultBackoffSettings()
     );
     return decodeOperation as LROperation<
       protos.google.cloud.run.v2.Revision,
@@ -791,7 +791,7 @@ export class RevisionsClient {
     const callSettings = defaultCallSettings.merge(options);
     this.initialize();
     return this.descriptors.page.listRevisions.createStream(
-      this.innerApiCalls.listRevisions as gax.GaxCall,
+      this.innerApiCalls.listRevisions as GaxCall,
       request,
       callSettings
     );
@@ -856,7 +856,7 @@ export class RevisionsClient {
     this.initialize();
     return this.descriptors.page.listRevisions.asyncIterate(
       this.innerApiCalls['listRevisions'] as GaxCall,
-      request as unknown as RequestType,
+      request as {},
       callSettings
     ) as AsyncIterable<protos.google.cloud.run.v2.IRevision>;
   }
diff --git a/packages/google-cloud-run/src/v2/services_client.ts b/packages/google-cloud-run/src/v2/services_client.ts
@@ -30,7 +30,6 @@ import {
 } from 'google-gax';
 
 import {Transform} from 'stream';
-import {RequestType} from 'google-gax/build/src/apitypes';
 import * as protos from '../../protos/protos';
 import jsonProtos = require('../../protos/protos.json');
 /**
@@ -337,7 +336,8 @@ export class ServicesClient {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
@@ -920,7 +920,7 @@ export class ServicesClient {
     const decodeOperation = new gax.Operation(
       operation,
       this.descriptors.longrunning.createService,
-      gax.createDefaultBackoffSettings()
+      this._gaxModule.createDefaultBackoffSettings()
     );
     return decodeOperation as LROperation<
       protos.google.cloud.run.v2.Service,
@@ -1075,7 +1075,7 @@ export class ServicesClient {
     const decodeOperation = new gax.Operation(
       operation,
       this.descriptors.longrunning.updateService,
-      gax.createDefaultBackoffSettings()
+      this._gaxModule.createDefaultBackoffSettings()
     );
     return decodeOperation as LROperation<
       protos.google.cloud.run.v2.Service,
@@ -1232,7 +1232,7 @@ export class ServicesClient {
     const decodeOperation = new gax.Operation(
       operation,
       this.descriptors.longrunning.deleteService,
-      gax.createDefaultBackoffSettings()
+      this._gaxModule.createDefaultBackoffSettings()
     );
     return decodeOperation as LROperation<
       protos.google.cloud.run.v2.Service,
@@ -1400,7 +1400,7 @@ export class ServicesClient {
     const callSettings = defaultCallSettings.merge(options);
     this.initialize();
     return this.descriptors.page.listServices.createStream(
-      this.innerApiCalls.listServices as gax.GaxCall,
+      this.innerApiCalls.listServices as GaxCall,
       request,
       callSettings
     );
@@ -1464,7 +1464,7 @@ export class ServicesClient {
     this.initialize();
     return this.descriptors.page.listServices.asyncIterate(
       this.innerApiCalls['listServices'] as GaxCall,
-      request as unknown as RequestType,
+      request as {},
       callSettings
     ) as AsyncIterable<protos.google.cloud.run.v2.IService>;
   }
diff --git a/packages/google-cloud-run/test/gapic_revisions_v2.ts b/packages/google-cloud-run/test/gapic_revisions_v2.ts
diff --git a/packages/google-cloud-run/test/gapic_services_v2.ts b/packages/google-cloud-run/test/gapic_services_v2.ts

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`"segments": [`
`23`	`23`	`{`
`24`	`24`	`"start": 25,`
`25`		`- "end": 52,`
	`25`	`+ "end": 55,`
`26`	`26`	`"type": "FULL"`
`27`	`27`	`}`
`28`	`28`	`],`
`@@ -62,7 +62,7 @@`
`62`	`62`	`"segments": [`
`63`	`63`	`{`
`64`	`64`	`"start": 25,`
`65`		`- "end": 68,`
	`65`	`+ "end": 71,`
`66`	`66`	`"type": "FULL"`
`67`	`67`	`}`
`68`	`68`	`],`
`@@ -114,7 +114,7 @@`
`114`	`114`	`"segments": [`
`115`	`115`	`{`
`116`	`116`	`"start": 25,`
`117`		`- "end": 63,`
	`117`	`+ "end": 66,`
`118`	`118`	`"type": "FULL"`
`119`	`119`	`}`
`120`	`120`	`],`
`@@ -162,7 +162,7 @@`
`162`	`162`	`"segments": [`
`163`	`163`	`{`
`164`	`164`	`"start": 25,`
`165`		`- "end": 68,`
	`165`	`+ "end": 71,`
`166`	`166`	`"type": "FULL"`
`167`	`167`	`}`
`168`	`168`	`],`
`@@ -214,7 +214,7 @@`
`214`	`214`	`"segments": [`
`215`	`215`	`{`
`216`	`216`	`"start": 25,`
`217`		`- "end": 51,`
	`217`	`+ "end": 54,`
`218`	`218`	`"type": "FULL"`
`219`	`219`	`}`
`220`	`220`	`],`
`@@ -254,7 +254,7 @@`
`254`	`254`	`"segments": [`
`255`	`255`	`{`
`256`	`256`	`"start": 25,`
`257`		`- "end": 67,`
	`257`	`+ "end": 70,`
`258`	`258`	`"type": "FULL"`
`259`	`259`	`}`
`260`	`260`	`],`
`@@ -306,7 +306,7 @@`
`306`	`306`	`"segments": [`
`307`	`307`	`{`
`308`	`308`	`"start": 25,`
`309`		`- "end": 62,`
	`309`	`+ "end": 65,`
`310`	`310`	`"type": "FULL"`
`311`	`311`	`}`
`312`	`312`	`],`
`@@ -354,7 +354,7 @@`
`354`	`354`	`"segments": [`
`355`	`355`	`{`
`356`	`356`	`"start": 25,`
`357`		`- "end": 62,`
	`357`	`+ "end": 65,`
`358`	`358`	`"type": "FULL"`
`359`	`359`	`}`
`360`	`360`	`],`
`@@ -402,7 +402,7 @@`
`402`	`402`	`"segments": [`
`403`	`403`	`{`
`404`	`404`	`"start": 25,`
`405`		`- "end": 56,`
	`405`	`+ "end": 59,`
`406`	`406`	`"type": "FULL"`
`407`	`407`	`}`
`408`	`408`	`],`
`@@ -446,7 +446,7 @@`
`446`	`446`	`"segments": [`
`447`	`447`	`{`
`448`	`448`	`"start": 25,`
`449`		`- "end": 66,`
	`449`	`+ "end": 69,`
`450`	`450`	`"type": "FULL"`
`451`	`451`	`}`
`452`	`452`	`],`
`@@ -494,7 +494,7 @@`
`494`	`494`	`"segments": [`
`495`	`495`	`{`
`496`	`496`	`"start": 25,`
`497`		`- "end": 59,`
	`497`	`+ "end": 62,`
`498`	`498`	`"type": "FULL"`
`499`	`499`	`}`
`500`	`500`	`],`