Skip to content

Commit 89b74b0

Browse files
storage: pass metadata during stream upload
1 parent 5284a39 commit 89b74b0

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

lib/common/util.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,9 @@ function makeWritableStream(dup, options, onComplete) {
304304
// Write the metadata to the request.
305305
stream.write('--' + boundary + '\n');
306306
stream.write('Content-Type: application/json\n\n');
307-
stream.write(JSON.stringify(options.metadata));
307+
stream.write(JSON.stringify({
308+
metadata: options.metadata
309+
}));
308310
stream.write('\n\n');
309311
stream.write('--' + boundary + '\n');
310312
stream.write('Content-Type: ' + streamType + '\n\n');

regression/storage.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -374,9 +374,12 @@ describe('storage', function() {
374374
});
375375
});
376376

377-
it('should write metadata', function(done) {
377+
it.only('should write metadata', function(done) {
378378
var options = {
379-
metadata: { contentType: 'image/png' },
379+
metadata: {
380+
contentType: 'image/png',
381+
property: 'value'
382+
},
380383
resumable: false
381384
};
382385

@@ -386,6 +389,7 @@ describe('storage', function() {
386389
file.getMetadata(function(err, metadata) {
387390
assert.ifError(err);
388391
assert.equal(metadata.contentType, options.metadata.contentType);
392+
assert.equal(metadata.metadata.property, options.metadata.property);
389393
file.delete(done);
390394
});
391395
});

test/common/util.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,9 @@ describe('common/util', function() {
210210
assert(endFirstBoundaryIdx > startFirstBoundaryIdx);
211211
assert(endBoundaryIdx > -1);
212212

213-
assert(written.indexOf(JSON.stringify(metadata)) > -1);
213+
assert(written.indexOf(JSON.stringify({
214+
metadata: metadata
215+
})) > -1);
214216

215217
done();
216218
};

0 commit comments

Comments
 (0)