Skip to content

Commit 876d5b6

Browse files
committed
remove dependency on common-grpc
1 parent a08e5c7 commit 876d5b6

File tree

4 files changed

+9
-17
lines changed

4 files changed

+9
-17
lines changed

packages/pubsub/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
],
5353
"dependencies": {
5454
"@google-cloud/common": "^0.13.0",
55-
"@google-cloud/common-grpc": "^0.4.2",
5655
"arrify": "^1.0.0",
5756
"async-each": "^1.0.1",
5857
"extend": "^3.0.0",

packages/pubsub/src/connection-pool.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ var arrify = require('arrify');
2424
var common = require('@google-cloud/common');
2525
var each = require('async-each');
2626
var events = require('events');
27-
var grpc = require('@google-cloud/common-grpc').grpc;
27+
var grpc = require('google-gax').grpc().grpc;
2828
var is = require('is');
2929
var util = require('util');
3030
var uuid = require('uuid');

packages/pubsub/test/connection-pool.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ var fakeUtil = extend({}, common.util);
3232
var fakeUuid = extend({}, uuid);
3333
var fakeGrpc = extend({}, grpc);
3434

35+
function fakeGaxGrpc() {
36+
return {
37+
grpc: fakeGrpc
38+
};
39+
}
40+
3541
var v1Override;
3642
function fakeV1(options) {
3743
return (v1Override || v1)(options);
@@ -95,8 +101,8 @@ describe('ConnectionPool', function() {
95101
'@google-cloud/common': {
96102
util: fakeUtil
97103
},
98-
'@google-cloud/common-grpc': {
99-
grpc: fakeGrpc
104+
'google-gax': {
105+
grpc: fakeGaxGrpc
100106
},
101107
uuid: fakeUuid,
102108
'./v1': fakeV1

packages/pubsub/test/iam.js

-13
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818

1919
var assert = require('assert');
2020
var extend = require('extend');
21-
var GrpcService = require('@google-cloud/common-grpc').Service;
22-
var nodeutil = require('util');
23-
var path = require('path');
2421
var proxyquire = require('proxyquire');
2522
var util = require('@google-cloud/common').util;
2623

@@ -33,13 +30,6 @@ var fakeUtil = extend({}, util, {
3330
}
3431
});
3532

36-
function FakeGrpcService() {
37-
this.calledWith_ = arguments;
38-
GrpcService.apply(this, arguments);
39-
}
40-
41-
nodeutil.inherits(FakeGrpcService, GrpcService);
42-
4333
describe('IAM', function() {
4434
var IAM;
4535
var iam;
@@ -54,9 +44,6 @@ describe('IAM', function() {
5444
IAM = proxyquire('../src/iam.js', {
5545
'@google-cloud/common': {
5646
util: fakeUtil
57-
},
58-
'@google-cloud/common-grpc': {
59-
Service: FakeGrpcService
6047
}
6148
});
6249
});

0 commit comments

Comments
 (0)