honor a default $TTL (#27)

Author: stephenplusplus

packages/google-cloud-dns/src/zone.js

@@ -1003,13 +1003,17 @@ Zone.prototype.import = function(localPath, callback) {
     }
 
     var parsedZonefile = zonefile.parse(file);
+    var defaultTTL = parsedZonefile.$ttl;
+    delete parsedZonefile.$ttl;
+
     var recordTypes = Object.keys(parsedZonefile);
     var recordsToCreate = [];
 
     recordTypes.forEach(function(recordType) {
       var recordTypeSet = arrify(parsedZonefile[recordType]);
 
       recordTypeSet.forEach(function(record) {
+        record.ttl = record.ttl || defaultTTL;
         recordsToCreate.push(Record.fromZoneRecord_(self, recordType, record));
       });
     });

packages/google-cloud-dns/system-test/data/zonefile.zone

@@ -1,2 +1,3 @@
+$TTL 3600
 {DNS_DOMAIN} 21600 IN SPF "v=spf1" "mx:{DNS_DOMAIN}" "-all"
-{DNS_DOMAIN} 21600 IN TXT "google-site-verification=xxxxxxxxxxxxYYYYYYXXX"
+{DNS_DOMAIN} IN TXT "google-site-verification=xxxxxxxxxxxxYYYYYYXXX"

packages/google-cloud-dns/test/zone.js

@@ -804,9 +804,12 @@ describe('Zone', function() {
     describe('success', function() {
       var recordType = 'ns';
       var parsedZonefile = {};
-      parsedZonefile[recordType] = {a: 'b', c: 'd'};
 
       beforeEach(function() {
+        parsedZonefile = {
+          [recordType]: {a: 'b', c: 'd'},
+        };
+
         parseOverride = function() {
           return parsedZonefile;
         };
@@ -834,6 +837,26 @@ describe('Zone', function() {
 
         zone.import(path, done);
       });
+
+      it('should use the default ttl', function(done) {
+        var defaultTTL = '90';
+
+        parsedZonefile.$ttl = defaultTTL;
+        parsedZonefile[recordType] = {};
+        parsedZonefile.mx = {ttl: '180'};
+
+        zone.addRecords = function(recordsToCreate) {
+          var record1 = recordsToCreate[0].calledWith_[2];
+          assert.strictEqual(record1.ttl, defaultTTL);
+
+          var record2 = recordsToCreate[1].calledWith_[2];
+          assert.strictEqual(record2.ttl, '180');
+
+          done();
+        };
+
+        zone.import(path, done);
+      });
     });
   });