Skip to content

Commit 7341476

Browse files
sofislsummer-ji-enggcf-owl-bot[bot]
authored
build!: update library to use Node 12 (#524)
* build!: Update library to use Node 12 Co-authored-by: Summer Ji <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 37d538b commit 7341476

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

packages/google-cloud-dns/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"license": "Apache-2.0",
66
"author": "Google Inc.",
77
"engines": {
8-
"node": ">=10"
8+
"node": ">=12.0.0"
99
},
1010
"repository": "googleapis/nodejs-dns",
1111
"main": "./build/src/index.js",
@@ -67,10 +67,10 @@
6767
"jsdoc-fresh": "^1.0.1",
6868
"jsdoc-region-tag": "^1.0.2",
6969
"linkinator": "^2.0.0",
70-
"mocha": "^8.0.0",
70+
"mocha": "^9.2.2",
7171
"proxyquire": "^2.0.1",
7272
"tmp": "^0.2.0",
73-
"typescript": "^3.8.3",
73+
"typescript": "^4.6.4",
7474
"uuid": "^8.0.0"
7575
}
7676
}

packages/google-cloud-dns/samples/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"author": "Google Inc.",
66
"repository": "googleapis/nodejs-dns",
77
"engines": {
8-
"node": ">=10"
8+
"node": ">=12.0.0"
99
},
1010
"files": [
1111
"*.js",
@@ -22,4 +22,4 @@
2222
"mocha": "^8.0.0",
2323
"uuid": "^8.0.0"
2424
}
25-
}
25+
}

packages/google-cloud-dns/test/record.ts

+7-2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ import * as proxyquire from 'proxyquire';
2020
// eslint-disable-next-line @typescript-eslint/no-unused-vars
2121
import {Record} from '../src';
2222

23+
interface Metadata {
24+
name: string;
25+
data?: string[];
26+
ttl: number;
27+
}
2328
let promisified = false;
2429
const fakePromisify = Object.assign({}, promisify, {
2530
promisifyAll(esClass: Function, options: promisify.PromisifyAllOptions) {
@@ -292,7 +297,7 @@ describe('Record', () => {
292297
});
293298

294299
describe('delete', () => {
295-
it('should call zone.deleteRecords', done => {
300+
it('should call zone.deleteRecords', (done: any) => {
296301
record.zone_.deleteRecords = (records: Record[], callback: Function) => {
297302
assert.strictEqual(records, record);
298303
callback();
@@ -303,7 +308,7 @@ describe('Record', () => {
303308

304309
describe('toJSON', () => {
305310
it('should format the data for the API', () => {
306-
const expectedRecord = Object.assign({}, METADATA, {
311+
const expectedRecord: Metadata = Object.assign({}, METADATA, {
307312
type: 'A',
308313
rrdatas: METADATA.data,
309314
});

0 commit comments

Comments
 (0)