Skip to content

Commit 5fac7c7

Browse files
yoshi-automationJustinBeckwith
authored andcommitted
feat: support apiEndpoint override in client constructor (#206)
1 parent 4933a70 commit 5fac7c7

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

packages/google-cloud-oslogin/src/v1beta/os_login_service_client.js

+1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ class OsLoginServiceClient {
5858
* API remote host.
5959
*/
6060
constructor(opts) {
61+
opts = opts || {};
6162
this._descriptors = {};
6263

6364
const servicePath =

packages/google-cloud-oslogin/synth.metadata

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
{
2-
"updateTime": "2019-06-04T19:38:15.784953Z",
2+
"updateTime": "2019-06-05T11:11:11.250834Z",
33
"sources": [
44
{
55
"generator": {
66
"name": "artman",
7-
"version": "0.23.0",
8-
"dockerImage": "googleapis/artman@sha256:846102ebf7ea2239162deea69f64940443b4147f7c2e68d64b332416f74211ba"
7+
"version": "0.23.1",
8+
"dockerImage": "googleapis/artman@sha256:9d5cae1454da64ac3a87028f8ef486b04889e351c83bb95e83b8fab3959faed0"
99
}
1010
},
1111
{
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "https://github.com/googleapis/googleapis.git",
15-
"sha": "0026f4b890ed9e2388fb0573c0727defa6f5b82e",
16-
"internalRef": "251265049"
15+
"sha": "4f3516a6f96dac182973a3573ff5117e8e4f76c7",
16+
"internalRef": "251559960"
1717
}
1818
},
1919
{

packages/google-cloud-oslogin/test/gapic-v1beta.js

+5
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ describe('OsLoginServiceClient', () => {
3939
assert(typeof port === 'number');
4040
});
4141

42+
it('should create a client with no options', () => {
43+
const client = new osLoginModule.v1beta.OsLoginServiceClient();
44+
assert(client);
45+
});
46+
4247
describe('deletePosixAccount', () => {
4348
it('invokes deletePosixAccount without error', done => {
4449
const client = new osLoginModule.v1beta.OsLoginServiceClient({

0 commit comments

Comments
 (0)