Skip to content

Commit 5ef90f4

Browse files
jkwluiJustinBeckwith
jkwlui
authored and
JustinBeckwith
committed
chore: assert.deelEqual => assert.deepStrictEqual (#137)
* chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual * chore: assert.deelEqual => assert.deepStrictEqual
1 parent a108e9b commit 5ef90f4

File tree

18 files changed

+182
-182
lines changed

18 files changed

+182
-182
lines changed

‎packages/google-cloud-compute/system-test/compute.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ describe('Compute', function() {
150150

151151
assert.strictEqual(metadata.name, AUTOSCALER_NAME);
152152

153-
assert.deepEqual(metadata.autoscalingPolicy, {
153+
assert.deepStrictEqual(metadata.autoscalingPolicy, {
154154
coolDownPeriodSec: 30,
155155
cpuUtilization: {
156156
utilizationTarget: 0.8,
@@ -305,8 +305,8 @@ describe('Compute', function() {
305305
it('should have opened the correct connections', function(done) {
306306
firewall.getMetadata(function(err, metadata) {
307307
assert.ifError(err);
308-
assert.deepEqual(metadata.allowed, expectedMetadata.allowed);
309-
assert.deepEqual(metadata.sourceRanges, expectedMetadata.sourceRanges);
308+
assert.deepStrictEqual(metadata.allowed, expectedMetadata.allowed);
309+
assert.deepStrictEqual(metadata.sourceRanges, expectedMetadata.sourceRanges);
310310
done();
311311
});
312312
});
@@ -545,7 +545,7 @@ describe('Compute', function() {
545545

546546
assert.strictEqual(metadata.name, INSTANCE_GROUP_NAME);
547547
assert.strictEqual(metadata.description, OPTIONS.description);
548-
assert.deepEqual(metadata.namedPorts, [
548+
assert.deepStrictEqual(metadata.namedPorts, [
549549
{
550550
name: 'http',
551551
port: 80,
@@ -612,7 +612,7 @@ describe('Compute', function() {
612612

613613
instanceGroup.getMetadata(function(err, metadata) {
614614
assert.ifError(err);
615-
assert.deepEqual(metadata.namedPorts, [
615+
assert.deepStrictEqual(metadata.namedPorts, [
616616
{
617617
name: 'http',
618618
port: 80,
@@ -1271,7 +1271,7 @@ describe('Compute', function() {
12711271
it('should have enabled HTTP connections', function(done) {
12721272
vm.getTags(function(err, tags) {
12731273
assert.ifError(err);
1274-
assert.deepEqual(tags, ['http-server']);
1274+
assert.deepStrictEqual(tags, ['http-server']);
12751275
done();
12761276
});
12771277
});
@@ -1402,7 +1402,7 @@ describe('Compute', function() {
14021402
vm.getMetadata(function(err, metadata) {
14031403
assert.ifError(err);
14041404

1405-
assert.deepEqual(metadata.metadata.items, [
1405+
assert.deepStrictEqual(metadata.metadata.items, [
14061406
{
14071407
key: key,
14081408
value: value,

‎packages/google-cloud-compute/test/address.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ describe('Address', function() {
9292
assert.strictEqual(calledWith.parent, regionInstance);
9393
assert.strictEqual(calledWith.baseUrl, '/addresses');
9494
assert.strictEqual(calledWith.id, ADDRESS_NAME);
95-
assert.deepEqual(calledWith.methods, {
95+
assert.deepStrictEqual(calledWith.methods, {
9696
create: true,
9797
exists: true,
9898
get: true,

‎packages/google-cloud-compute/test/autoscaler.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ describe('Autoscaler', function() {
9999
assert.strictEqual(calledWith.baseUrl, '/autoscalers');
100100
assert.strictEqual(calledWith.id, AUTOSCALER_NAME);
101101
assert.strictEqual(calledWith.createMethod, createMethod);
102-
assert.deepEqual(calledWith.methods, {
102+
assert.deepStrictEqual(calledWith.methods, {
103103
create: true,
104104
exists: true,
105105
get: true,
@@ -188,7 +188,7 @@ describe('Autoscaler', function() {
188188
assert.strictEqual(reqOpts.method, 'PATCH');
189189
assert.strictEqual(reqOpts.uri, '/autoscalers');
190190
assert.strictEqual(reqOpts.json, metadata);
191-
assert.deepEqual(metadata, {
191+
assert.deepStrictEqual(metadata, {
192192
name: autoscaler.name,
193193
zone: ZONE.name,
194194
});

‎packages/google-cloud-compute/test/disk.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ var fakeUtil = extend({}, util, {
3232
}
3333

3434
promisified = true;
35-
assert.deepEqual(options.exclude, ['snapshot']);
35+
assert.deepStrictEqual(options.exclude, ['snapshot']);
3636
},
3737
});
3838

@@ -130,7 +130,7 @@ describe('Disk', function() {
130130
assert.strictEqual(calledWith.parent, zoneInstance);
131131
assert.strictEqual(calledWith.baseUrl, '/disks');
132132
assert.strictEqual(calledWith.id, DISK_NAME);
133-
assert.deepEqual(calledWith.methods, {
133+
assert.deepStrictEqual(calledWith.methods, {
134134
create: true,
135135
exists: true,
136136
get: true,
@@ -151,7 +151,7 @@ describe('Disk', function() {
151151
disk.request = function(reqOpts) {
152152
assert.strictEqual(reqOpts.method, 'POST');
153153
assert.strictEqual(reqOpts.uri, '/createSnapshot');
154-
assert.deepEqual(reqOpts.json, {name: 'test', a: 'b'});
154+
assert.deepStrictEqual(reqOpts.json, {name: 'test', a: 'b'});
155155
done();
156156
};
157157

‎packages/google-cloud-compute/test/firewall.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ describe('Firewall', function() {
7777
});
7878

7979
it('should default to the global network', function() {
80-
assert.deepEqual(firewall.metadata, {network: FIREWALL_NETWORK});
80+
assert.deepStrictEqual(firewall.metadata, {network: FIREWALL_NETWORK});
8181
});
8282

8383
it('should inherit from ServiceObject', function() {
@@ -98,7 +98,7 @@ describe('Firewall', function() {
9898
assert.strictEqual(calledWith.parent, computeInstance);
9999
assert.strictEqual(calledWith.baseUrl, '/global/firewalls');
100100
assert.strictEqual(calledWith.id, FIREWALL_NAME);
101-
assert.deepEqual(calledWith.methods, {
101+
assert.deepStrictEqual(calledWith.methods, {
102102
create: true,
103103
exists: true,
104104
get: true,
@@ -187,7 +187,7 @@ describe('Firewall', function() {
187187
assert.strictEqual(reqOpts.method, 'PATCH');
188188
assert.strictEqual(reqOpts.uri, '');
189189
assert.strictEqual(reqOpts.json, metadata);
190-
assert.deepEqual(metadata, {
190+
assert.deepStrictEqual(metadata, {
191191
name: firewall.name,
192192
network: FIREWALL_NETWORK,
193193
});

‎packages/google-cloud-compute/test/health-check.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe('HealthCheck', function() {
7373

7474
assert.strictEqual(calledWith.parent, COMPUTE);
7575
assert.strictEqual(calledWith.id, HEALTH_CHECK_NAME);
76-
assert.deepEqual(calledWith.methods, {
76+
assert.deepStrictEqual(calledWith.methods, {
7777
create: true,
7878
exists: true,
7979
get: true,
@@ -101,8 +101,8 @@ describe('HealthCheck', function() {
101101

102102
COMPUTE.createHealthCheck = function(name, opts, callback) {
103103
assert.strictEqual(name, NAME);
104-
assert.deepEqual(opts, OPTIONS);
105-
assert.deepEqual(OPTIONS, originalOptions);
104+
assert.deepStrictEqual(opts, OPTIONS);
105+
assert.deepStrictEqual(OPTIONS, originalOptions);
106106
callback(); // done()
107107
};
108108

@@ -113,7 +113,7 @@ describe('HealthCheck', function() {
113113
var createMethod = healthCheck.calledWith_[0].createMethod;
114114

115115
COMPUTE.createHealthCheck = function(name, opts, callback) {
116-
assert.deepEqual(opts, {});
116+
assert.deepStrictEqual(opts, {});
117117
callback(); // done()
118118
};
119119

@@ -145,8 +145,8 @@ describe('HealthCheck', function() {
145145

146146
COMPUTE.createHealthCheck = function(name, opts, callback) {
147147
assert.strictEqual(name, NAME);
148-
assert.deepEqual(opts, extend({https: true}, OPTIONS));
149-
assert.deepEqual(OPTIONS, originalOptions);
148+
assert.deepStrictEqual(opts, extend({https: true}, OPTIONS));
149+
assert.deepStrictEqual(OPTIONS, originalOptions);
150150
callback(); // done()
151151
};
152152

@@ -157,7 +157,7 @@ describe('HealthCheck', function() {
157157
var createMethod = healthCheck.calledWith_[0].createMethod;
158158

159159
COMPUTE.createHealthCheck = function(name, opts, callback) {
160-
assert.deepEqual(opts, {https: true});
160+
assert.deepStrictEqual(opts, {https: true});
161161
callback(); // done()
162162
};
163163

0 commit comments

Comments
 (0)