Skip to content

Commit 4c84d04

Browse files
JustinBeckwithstephenplusplus
authored andcommitted
test: fail when system-tests do not run (#86)
1 parent b768f7f commit 4c84d04

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

packages/google-cloud-dns/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@
7474
"eslint-config-prettier": "^3.0.0",
7575
"eslint-plugin-node": "^7.0.0",
7676
"eslint-plugin-prettier": "^2.6.0",
77-
"extend": "^3.0.1",
7877
"ink-docstrap": "^1.3.2",
7978
"intelli-espower-loader": "^1.0.1",
8079
"jsdoc": "^3.5.5",

packages/google-cloud-dns/system-test/dns.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,14 @@ const DNS = require('../');
2929
const dns = new DNS();
3030
const DNS_DOMAIN = process.env.GCLOUD_TESTS_DNS_DOMAIN;
3131

32+
if (!DNS_DOMAIN) {
33+
assert.fail(
34+
`The 'GCLOUD_TESTS_DNS_DOMAIN' environment variable must be set to run the system tests.`
35+
);
36+
}
37+
3238
// Only run the tests if there is a domain to test with.
33-
(DNS_DOMAIN ? describe : describe.skip)('dns', function() {
39+
describe('dns', function() {
3440
if (!DNS_DOMAIN) {
3541
// The test runner still executes this function, even if it is skipped.
3642
return;

0 commit comments

Comments
 (0)