fix: DEADLINE_EXCEEDED retry code is idempotent (#234)

yoshi-automation · JustinBeckwith · commit 2eb8cae61dcf · 2019-05-10T23:01:51.000Z
diff --git a/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client.js b/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client.js
@@ -269,7 +269,7 @@ class VideoIntelligenceServiceClient {
    *   // optional auth parameters.
    * });
    *
-   * const inputUri = 'gs://videodemomaker/cat.mp4';
+   * const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
    * const featuresElement = 'LABEL_DETECTION';
    * const features = [featuresElement];
    * const request = {
@@ -294,7 +294,7 @@ class VideoIntelligenceServiceClient {
    *     console.error(err);
    *   });
    *
-   * const inputUri = 'gs://videodemomaker/cat.mp4';
+   * const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
    * const featuresElement = 'LABEL_DETECTION';
    * const features = [featuresElement];
    * const request = {
@@ -328,7 +328,7 @@ class VideoIntelligenceServiceClient {
    *     console.error(err);
    *   });
    *
-   * const inputUri = 'gs://videodemomaker/cat.mp4';
+   * const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
    * const featuresElement = 'LABEL_DETECTION';
    * const features = [featuresElement];
    * const request = {
diff --git a/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
     "google.cloud.videointelligence.v1.VideoIntelligenceService": {
       "retry_codes": {
         "idempotent": [
+          "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
         "non_idempotent": []
diff --git a/packages/google-cloud-videointelligence/src/v1beta1/video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
     "google.cloud.videointelligence.v1beta1.VideoIntelligenceService": {
       "retry_codes": {
         "idempotent": [
+          "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
         "non_idempotent": []
diff --git a/packages/google-cloud-videointelligence/src/v1beta2/video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1beta2/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
     "google.cloud.videointelligence.v1beta2.VideoIntelligenceService": {
       "retry_codes": {
         "idempotent": [
+          "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
         "non_idempotent": []
diff --git a/packages/google-cloud-videointelligence/src/v1p1beta1/video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1p1beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
     "google.cloud.videointelligence.v1p1beta1.VideoIntelligenceService": {
       "retry_codes": {
         "idempotent": [
+          "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
         "non_idempotent": []
diff --git a/packages/google-cloud-videointelligence/src/v1p2beta1/video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1p2beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
     "google.cloud.videointelligence.v1p2beta1.VideoIntelligenceService": {
       "retry_codes": {
         "idempotent": [
+          "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
         "non_idempotent": []
diff --git a/packages/google-cloud-videointelligence/src/v1p3beta1/streaming_video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1p3beta1/streaming_video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
     "google.cloud.videointelligence.v1p3beta1.StreamingVideoIntelligenceService": {
       "retry_codes": {
         "idempotent": [
+          "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
         "non_idempotent": []
diff --git a/packages/google-cloud-videointelligence/src/v1p3beta1/video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1p3beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
     "google.cloud.videointelligence.v1p3beta1.VideoIntelligenceService": {
       "retry_codes": {
         "idempotent": [
+          "DEADLINE_EXCEEDED",
           "UNAVAILABLE"
         ],
         "non_idempotent": []
diff --git a/packages/google-cloud-videointelligence/synth.metadata b/packages/google-cloud-videointelligence/synth.metadata
@@ -1,5 +1,5 @@
 {
-  "updateTime": "2019-05-09T11:25:45.168969Z",
+  "updateTime": "2019-05-10T12:18:43.741935Z",
   "sources": [
     {
       "generator": {
@@ -12,8 +12,8 @@
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "2f6e293d9a0097167ed5160fd366403c21b5fa49",
-        "internalRef": "247230302"
+        "sha": "07883be5bf3c3233095e99d8e92b8094f5d7084a",
+        "internalRef": "247530843"
       }
     },
     {
diff --git a/packages/google-cloud-videointelligence/test/gapic-v1.js b/packages/google-cloud-videointelligence/test/gapic-v1.js
@@ -33,7 +33,7 @@ describe('VideoIntelligenceServiceClient', () => {
       );
 
       // Mock request
-      const inputUri = 'gs://videodemomaker/cat.mp4';
+      const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
       const featuresElement = 'LABEL_DETECTION';
       const features = [featuresElement];
       const request = {
@@ -74,7 +74,7 @@ describe('VideoIntelligenceServiceClient', () => {
       );
 
       // Mock request
-      const inputUri = 'gs://videodemomaker/cat.mp4';
+      const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
       const featuresElement = 'LABEL_DETECTION';
       const features = [featuresElement];
       const request = {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "updateTime": "2019-05-09T11:25:45.168969Z",`
	`2`	`+ "updateTime": "2019-05-10T12:18:43.741935Z",`
`3`	`3`	`"sources": [`
`4`	`4`	`{`
`5`	`5`	`"generator": {`
`@@ -12,8 +12,8 @@`
`12`	`12`	`"git": {`
`13`	`13`	`"name": "googleapis",`
`14`	`14`	`"remote": "https://github.com/googleapis/googleapis.git",`
`15`		`- "sha": "2f6e293d9a0097167ed5160fd366403c21b5fa49",`
`16`		`- "internalRef": "247230302"`
	`15`	`+ "sha": "07883be5bf3c3233095e99d8e92b8094f5d7084a",`
	`16`	`+ "internalRef": "247530843"`
`17`	`17`	`}`
`18`	`18`	`},`
`19`	`19`	`{`