Skip to content

Commit 2b31d15

Browse files
committed
updated cluster links and option handling
1 parent 96eb260 commit 2b31d15

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ job.getQueryResults().on('data', function(row) {});
126126
- [API Documentation][gcloud-bigtable-docs]
127127
- [Official Documentation][cloud-bigtable-docs]
128128

129-
*You may need to [create a cluster][gcloud-bigtable-cluster] to use the Google Cloud Bigtable API with your project.*
129+
*You may need to [create a cluster][cloud-bigtable-cluster] to use the Google Cloud Bigtable API with your project.*
130130

131131
#### Preview
132132

@@ -740,7 +740,7 @@ Apache 2.0 - See [COPYING](COPYING) for more information.
740740
[cloud-bigquery-docs]: https://cloud.google.com/bigquery/what-is-bigquery
741741

742742
[cloud-bigtable-docs]: https://cloud.google.com/bigtable/docs/
743-
[cloud-bigtable-cluster]: https://cloud.google.com/bigtable/docs/creating-cluster
743+
[cloud-bigtable-cluster]: https://cloud.google.com/bigtable/docs/creating-compute-instance
744744

745745
[cloud-compute-docs]: https://cloud.google.com/compute/docs
746746

lib/bigtable/index.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ var googleProtoFiles = require('google-proto-files');
2424
var is = require('is');
2525
var nodeutil = require('util');
2626
var format = require('string-format-obj');
27+
var extend = require('extend');
2728

2829
/**
2930
* @type {module:bigtable/table}
@@ -56,7 +57,7 @@ var util = require('../common/util.js');
5657
* To learn more about Bigtable, read the
5758
* [Google Cloud Bigtable Concepts Overview](https://cloud.google.com/bigtable/docs/concepts)
5859
*
59-
* @resource [Creating a Cloud Bigtable Cluster]{@link https://cloud.google.com/bigtable/docs/creating-cluster}
60+
* @resource [Creating a Cloud Bigtable Cluster]{@link https://cloud.google.com/bigtable/docs/creating-compute-instance}
6061
*
6162
* @param {object=} options - [Configuration object](#/docs).
6263
* @param {string} options.cluster - The cluster name that hosts your tables.
@@ -80,7 +81,7 @@ var util = require('../common/util.js');
8081
* // Before you create your table, you first need to create a Bigtable Cluster
8182
* // for the table to be served from. This can be done from either the
8283
* // Google Cloud Platform Console or the `gcloud` cli tool. Please refer to
83-
* // the <a href="https://cloud.google.com/bigtable/docs/creating-cluster">
84+
* // the <a href="https://cloud.google.com/bigtable/docs/creating-compute-instance">
8485
* // official Bigtable documentation</a> for more information.
8586
* //-
8687
*
@@ -280,11 +281,9 @@ function Bigtable(options) {
280281
return new Bigtable(options);
281282
}
282283

283-
options = {
284-
projectId: options.projectId,
285-
zone: options.zone.name || options.zone,
286-
cluster: options.cluster
287-
};
284+
options = extend({}, options, {
285+
zone: options.zone.name || options.zone
286+
});
288287

289288
this.clusterName = format(
290289
'projects/{projectId}/zones/{zone}/clusters/{cluster}',

0 commit comments

Comments
 (0)