fix: remove the having enum value from GroupFindingsRequest (#67)

BREAKING CHANGE:  The `having` enum value has been removed from `GroupFindingsRequest`.  This property was never meant to be exposed.

Author: yoshi-automation

packages/google-cloud-securitycenter/protos/google/cloud/securitycenter/v1/securitycenter_service.proto

@@ -331,11 +331,6 @@ message GroupAssetsRequest {
   // NOW.
   google.protobuf.Timestamp read_time = 5;
 
-  // Filter that specifies what fields to further filter on *after* the query
-  // filter has been executed. Currently only 'state_change' is supported and
-  // requires compare_duration to be specified.
-  string having = 6;
-
   // The value returned by the last `GroupAssetsResponse`; indicates
   // that this is a continuation of a prior `GroupAssets` call, and that the
   // system should return the next page of data.
@@ -344,6 +339,8 @@ message GroupAssetsRequest {
   // The maximum number of results to return in a single response. Default is
   // 10, minimum is 1, maximum is 1000.
   int32 page_size = 8;
+
+  reserved 6;
 }
 
 // Response message for grouping by assets.
@@ -446,11 +443,6 @@ message GroupFindingsRequest {
   // `group_by`.
   google.protobuf.Duration compare_duration = 5;
 
-  // Filter that specifies what fields to further filter on *after* the query
-  // filter has been executed. Currently only 'finding.state' and 'state_change'
-  // are supported and requires compare_duration to be specified.
-  string having = 6;
-
   // The value returned by the last `GroupFindingsResponse`; indicates
   // that this is a continuation of a prior `GroupFindings` call, and
   // that the system should return the next page of data.
@@ -459,6 +451,8 @@ message GroupFindingsRequest {
   // The maximum number of results to return in a single response. Default is
   // 10, minimum is 1, maximum is 1000.
   int32 page_size = 8;
+
+  reserved 6;
 }
 
 // Response message for group by findings.
@@ -591,11 +585,6 @@ message ListAssetsRequest {
   // read_time.
   google.protobuf.Duration compare_duration = 5;
 
-  // Filter that specifies what fields to further filter on *after* the query
-  // filter has been executed. Currently only 'state_change' is supported and
-  // requires compare_duration to be specified.
-  string having = 6;
-
   // Optional.
   //
   // A field mask to specify the ListAssetsResult fields to be listed in the
@@ -611,6 +600,8 @@ message ListAssetsRequest {
   // The maximum number of results to return in a single response. Default is
   // 10, minimum is 1, maximum is 1000.
   int32 page_size = 9;
+
+  reserved 6;
 }
 
 // Response message for listing assets.
@@ -735,11 +726,6 @@ message ListFindingsRequest {
   // read_time.
   google.protobuf.Duration compare_duration = 5;
 
-  // Filter that specifies what fields to further filter on *after* the query
-  // filter has been executed. Currently only 'finding.state' and 'state_change'
-  // are supported and requires compare_duration to be specified.
-  string having = 6;
-
   // Optional.
   //
   // A field mask to specify the Finding fields to be listed in the response.
@@ -754,6 +740,8 @@ message ListFindingsRequest {
   // The maximum number of results to return in a single response. Default is
   // 10, minimum is 1, maximum is 1000.
   int32 page_size = 9;
+
+  reserved 6;
 }
 
 // Response message for listing findings.

packages/google-cloud-securitycenter/src/v1/doc/google/cloud/securitycenter/v1/doc_securitycenter_service.js

@@ -183,11 +183,6 @@ const GetSourceRequest = {
  *
  *   This object should have the same structure as [Timestamp]{@link google.protobuf.Timestamp}
  *
- * @property {string} having
- *   Filter that specifies what fields to further filter on *after* the query
- *   filter has been executed. Currently only 'state_change' is supported and
- *   requires compare_duration to be specified.
- *
  * @property {string} pageToken
  *   The value returned by the last `GroupAssetsResponse`; indicates
  *   that this is a continuation of a prior `GroupAssets` call, and that the
@@ -322,11 +317,6 @@ const GroupAssetsResponse = {
  *
  *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
  *
- * @property {string} having
- *   Filter that specifies what fields to further filter on *after* the query
- *   filter has been executed. Currently only 'finding.state' and 'state_change'
- *   are supported and requires compare_duration to be specified.
- *
  * @property {string} pageToken
  *   The value returned by the last `GroupFindingsResponse`; indicates
  *   that this is a continuation of a prior `GroupFindings` call, and
@@ -517,11 +507,6 @@ const ListSourcesResponse = {
  *
  *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
  *
- * @property {string} having
- *   Filter that specifies what fields to further filter on *after* the query
- *   filter has been executed. Currently only 'state_change' is supported and
- *   requires compare_duration to be specified.
- *
  * @property {Object} fieldMask
  *   Optional.
  *
@@ -713,11 +698,6 @@ const ListAssetsResponse = {
  *
  *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
  *
- * @property {string} having
- *   Filter that specifies what fields to further filter on *after* the query
- *   filter has been executed. Currently only 'finding.state' and 'state_change'
- *   are supported and requires compare_duration to be specified.
- *
  * @property {Object} fieldMask
  *   Optional.
  *

packages/google-cloud-securitycenter/src/v1/security_center_client.js

@@ -642,10 +642,6 @@ class SecurityCenterClient {
    *   NOW.
    *
    *   This object should have the same structure as [Timestamp]{@link google.protobuf.Timestamp}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'state_change' is supported and
-   *   requires compare_duration to be specified.
    * @param {number} [request.pageSize]
    *   The maximum number of resources contained in the underlying API
    *   response. If page streaming is performed per-resource, this
@@ -841,10 +837,6 @@ class SecurityCenterClient {
    *   NOW.
    *
    *   This object should have the same structure as [Timestamp]{@link google.protobuf.Timestamp}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'state_change' is supported and
-   *   requires compare_duration to be specified.
    * @param {number} [request.pageSize]
    *   The maximum number of resources contained in the underlying API
    *   response. If page streaming is performed per-resource, this
@@ -976,10 +968,6 @@ class SecurityCenterClient {
    *   `group_by`.
    *
    *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'finding.state' and 'state_change'
-   *   are supported and requires compare_duration to be specified.
    * @param {number} [request.pageSize]
    *   The maximum number of resources contained in the underlying API
    *   response. If page streaming is performed per-resource, this
@@ -1171,10 +1159,6 @@ class SecurityCenterClient {
    *   `group_by`.
    *
    *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'finding.state' and 'state_change'
-   *   are supported and requires compare_duration to be specified.
    * @param {number} [request.pageSize]
    *   The maximum number of resources contained in the underlying API
    *   response. If page streaming is performed per-resource, this
@@ -1297,10 +1281,6 @@ class SecurityCenterClient {
    *   read_time.
    *
    *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'state_change' is supported and
-   *   requires compare_duration to be specified.
    * @param {Object} [request.fieldMask]
    *   Optional.
    *
@@ -1485,10 +1465,6 @@ class SecurityCenterClient {
    *   read_time.
    *
    *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'state_change' is supported and
-   *   requires compare_duration to be specified.
    * @param {Object} [request.fieldMask]
    *   Optional.
    *
@@ -1617,10 +1593,6 @@ class SecurityCenterClient {
    *   read_time.
    *
    *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'finding.state' and 'state_change'
-   *   are supported and requires compare_duration to be specified.
    * @param {Object} [request.fieldMask]
    *   Optional.
    *
@@ -1804,10 +1776,6 @@ class SecurityCenterClient {
    *   read_time.
    *
    *   This object should have the same structure as [Duration]{@link google.protobuf.Duration}
-   * @param {string} [request.having]
-   *   Filter that specifies what fields to further filter on *after* the query
-   *   filter has been executed. Currently only 'finding.state' and 'state_change'
-   *   are supported and requires compare_duration to be specified.
    * @param {Object} [request.fieldMask]
    *   Optional.
    *

packages/google-cloud-securitycenter/synth.metadata

@@ -1,5 +1,5 @@
 {
-  "updateTime": "2019-03-13T11:21:18.503485Z",
+  "updateTime": "2019-03-14T11:20:21.875346Z",
   "sources": [
     {
       "generator": {
@@ -12,8 +12,8 @@
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "e340f4a01ec287f7bb86e2331b5e98c473d10afd",
-        "internalRef": "238151361"
+        "sha": "d05a746ba27b89374c7407c88c0d5dabfb0afc7c",
+        "internalRef": "238372434"
       }
     },
     {