Skip to content

Commit 24fbcdc

Browse files
faithseedstephenplusplus
authored andcommitted
Fix documentation that labels for logging entry has to be STRING (#1241)
1 parent 5199cad commit 24fbcdc

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ var resource = {
475475
type: 'gce_instance',
476476
labels: {
477477
zone: 'global',
478-
instance_id: 3
478+
instance_id: '3'
479479
}
480480
};
481481

lib/logging/entry.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ var GrpcService = require('../common/grpc-service.js');
5757
* type: 'gce_instance',
5858
* labels: {
5959
* zone: 'global',
60-
* instance_id: 3
60+
* instance_id: '3'
6161
* }
6262
* };
6363
*

lib/logging/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ Logging.prototype.createSink = function(name, config, callback) {
255255
* type: 'gce_instance',
256256
* labels: {
257257
* zone: 'global',
258-
* instance_id: 3
258+
* instance_id: '3'
259259
* }
260260
* };
261261
*
@@ -269,7 +269,7 @@ Logging.prototype.createSink = function(name, config, callback) {
269269
* // type: 'gce_instance',
270270
* // labels: {
271271
* // zone: 'global',
272-
* // instance_id: 3
272+
* // instance_id: '3'
273273
* // }
274274
* // },
275275
* // jsonPayload: {

lib/logging/log.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ Log.prototype.emergency = function(entry, options, callback) {
226226
* type: 'gce_instance',
227227
* labels: {
228228
* zone: 'global',
229-
* instance_id: 3
229+
* instance_id: '3'
230230
* }
231231
* };
232232
*
@@ -241,7 +241,7 @@ Log.prototype.emergency = function(entry, options, callback) {
241241
* // type: 'gce_instance',
242242
* // labels: {
243243
* // zone: 'global',
244-
* // instance_id: 3
244+
* // instance_id: '3'
245245
* // }
246246
* // },
247247
* // jsonPayload: {

0 commit comments

Comments
 (0)