Skip to content

Commit f8c8dc6

Browse files
committed
Addressing last comments of feedback
1 parent 6b3c738 commit f8c8dc6

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/MessagesProcessor.java

+2-15
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class MessagesProcessor {
6161
@VisibleForTesting static final Duration PENDING_ACKS_SEND_DELAY = Duration.millis(100);
6262
private static final int MAX_ACK_DEADLINE_EXTENSION_SECS = 10 * 60; // 10m
6363

64-
protected final ScheduledExecutorService executor;
64+
private final ScheduledExecutorService executor;
6565
private final Clock clock;
6666

6767
private final Duration ackExpirationPadding;
@@ -228,7 +228,7 @@ void sendAckOperations(
228228
this.clock = clock;
229229
}
230230

231-
protected void stop() {
231+
public void stop() {
232232
messagesWaiter.waitNoMessages();
233233
alarmsLock.lock();
234234
try {
@@ -242,19 +242,6 @@ protected void stop() {
242242
processOutstandingAckOperations();
243243
}
244244

245-
protected boolean isRetryable(Status status) {
246-
switch (status.getCode()) {
247-
case DEADLINE_EXCEEDED:
248-
case INTERNAL:
249-
case CANCELLED:
250-
case RESOURCE_EXHAUSTED:
251-
case UNAVAILABLE:
252-
return true;
253-
default:
254-
return false;
255-
}
256-
}
257-
258245
public void setMessageDeadlineSeconds(int messageDeadlineSeconds) {
259246
this.messageDeadlineSeconds = messageDeadlineSeconds;
260247
}

0 commit comments

Comments
 (0)