Skip to content

Commit 9699b46

Browse files
authored
ci: no need to check native-image-support gRPC convergence (#666)
I found googleapis/java-shared-dependencies#665 (comment) complains old gRPC version declared by "com.google.cloud:native-image-support" (provided scope). The artifact's gRPC dependency is irrelevant to users.
1 parent 7dd17f4 commit 9699b46

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

java-shared-dependencies/dependency-convergence-check/src/test/java/com/google/cloud/DependencyConvergenceTest.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ public void testGrpcConvergence() throws Exception {
5757
"opencensus-exporter-stats-stackdriver",
5858
// Because grpc-gcp's gRPC version does not use version range notation, it does not
5959
// break downstream build
60-
"grpc-gcp"));
60+
"grpc-gcp",
61+
// Because native-image-support's gRPC dependency is provided scope, it does not bring
62+
// inconsistent gRPC artifacts to users' class paths.
63+
"native-image-support"));
6164
}
6265

6366
/**

0 commit comments

Comments
 (0)