PR comment

pongad · pongad · commit 861a3186da44 · 2017-01-23T16:36:48.000+11:00
diff --git a/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/spi/v1/SubscriberImplTest.java b/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/spi/v1/SubscriberImplTest.java
@@ -145,11 +145,8 @@ public void replyNextOutstandingMessage() {
 
     public void replyAllOutstandingMessage() {
       Preconditions.checkState(explicitAckReplies);
-      for (; ; ) {
-        SettableFuture<AckReply> reply = outstandingMessageReplies.poll();
-        if (reply == null) {
-          return;
-        }
+      SettableFuture<AckReply> reply;
+      while ((reply = outstandingMessageReplies.poll()) != null) {
         replyTo(reply);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -145,11 +145,8 @@ public void replyNextOutstandingMessage() {`
`145`	`145`
`146`	`146`	`public void replyAllOutstandingMessage() {`
`147`	`147`	`Preconditions.checkState(explicitAckReplies);`
`148`		`- for (; ; ) {`
`149`		`- SettableFuture<AckReply> reply = outstandingMessageReplies.poll();`
`150`		`- if (reply == null) {`
`151`		`- return;`
`152`		`- }`
	`148`	`+ SettableFuture<AckReply> reply;`
	`149`	`+ while ((reply = outstandingMessageReplies.poll()) != null) {`
`153`	`150`	`replyTo(reply);`
`154`	`151`	`}`
`155`	`152`	`}`