Skip to content

Commit 484071c

Browse files
committed
Remove final from immutable resource classes
1 parent c41ad14 commit 484071c

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskType.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*
3333
* @see <a href="https://cloud.google.com/compute/docs/reference/latest/diskTypes">Disk Types</a>
3434
*/
35-
public final class DiskType implements Serializable {
35+
public class DiskType implements Serializable {
3636

3737
static final Function<com.google.api.services.compute.model.DiskType, DiskType> FROM_PB_FUNCTION =
3838
new Function<com.google.api.services.compute.model.DiskType, DiskType>() {
@@ -186,12 +186,12 @@ public String toString() {
186186
}
187187

188188
@Override
189-
public int hashCode() {
189+
public final int hashCode() {
190190
return Objects.hash(diskTypeId);
191191
}
192192

193193
@Override
194-
public boolean equals(Object obj) {
194+
public final boolean equals(Object obj) {
195195
return obj instanceof DiskType && Objects.equals(toPb(), ((DiskType) obj).toPb());
196196
}
197197

gcloud-java-compute/src/main/java/com/google/gcloud/compute/License.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*
3030
* @see <a href="https://cloud.google.com/compute/docs/reference/latest/licenses">Licenses</a>
3131
*/
32-
public final class License implements Serializable {
32+
public class License implements Serializable {
3333

3434
private static final long serialVersionUID = 6907923910319640363L;
3535

@@ -65,12 +65,12 @@ public String toString() {
6565
}
6666

6767
@Override
68-
public int hashCode() {
68+
public final int hashCode() {
6969
return Objects.hash(licenseId);
7070
}
7171

7272
@Override
73-
public boolean equals(Object obj) {
73+
public final boolean equals(Object obj) {
7474
return obj instanceof License && Objects.equals(toPb(), ((License) obj).toPb());
7575
}
7676

gcloud-java-compute/src/main/java/com/google/gcloud/compute/MachineType.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
*
3737
* @see <a href="https://cloud.google.com/compute/docs/machine-types">Machine Types</a>
3838
*/
39-
public final class MachineType implements Serializable {
39+
public class MachineType implements Serializable {
4040

4141
static final Function<com.google.api.services.compute.model.MachineType, MachineType>
4242
FROM_PB_FUNCTION =
@@ -242,12 +242,12 @@ public String toString() {
242242
}
243243

244244
@Override
245-
public int hashCode() {
245+
public final int hashCode() {
246246
return Objects.hash(machineTypeId);
247247
}
248248

249249
@Override
250-
public boolean equals(Object obj) {
250+
public final boolean equals(Object obj) {
251251
return obj instanceof MachineType && Objects.equals(toPb(), ((MachineType) obj).toPb());
252252
}
253253

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Region.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
*
3535
* @see <a href="https://cloud.google.com/compute/docs/zones">Region and Zones</a>
3636
*/
37-
public final class Region implements Serializable {
37+
public class Region implements Serializable {
3838

3939
static final Function<com.google.api.services.compute.model.Region, Region> FROM_PB_FUNCTION =
4040
new Function<com.google.api.services.compute.model.Region, Region>() {
@@ -306,12 +306,12 @@ public String toString() {
306306
}
307307

308308
@Override
309-
public int hashCode() {
309+
public final int hashCode() {
310310
return Objects.hash(regionId);
311311
}
312312

313313
@Override
314-
public boolean equals(Object obj) {
314+
public final boolean equals(Object obj) {
315315
return obj instanceof Region && Objects.equals(toPb(), ((Region) obj).toPb());
316316
}
317317

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Zone.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
*
3535
* @see <a href="https://cloud.google.com/compute/docs/zones">Region and Zones</a>
3636
*/
37-
public final class Zone implements Serializable {
37+
public class Zone implements Serializable {
3838

3939
static final Function<com.google.api.services.compute.model.Zone, Zone> FROM_PB_FUNCTION =
4040
new Function<com.google.api.services.compute.model.Zone, Zone>() {
@@ -325,12 +325,12 @@ public String toString() {
325325
}
326326

327327
@Override
328-
public int hashCode() {
328+
public final int hashCode() {
329329
return Objects.hash(zoneId);
330330
}
331331

332332
@Override
333-
public boolean equals(Object obj) {
333+
public final boolean equals(Object obj) {
334334
return obj instanceof Zone && Objects.equals(toPb(), ((Zone) obj).toPb());
335335
}
336336

0 commit comments

Comments
 (0)