Skip to content

Commit 302a937

Browse files
authored
hide Publisher and Subscriber's getStats() (#1555)
* hide Publisher and Subscriber's getStats() The methods are not yet implemented, so there is no reason to expose it. Another way out is to delete it for the time being. * delete the methods
1 parent 51a9a80 commit 302a937

File tree

4 files changed

+3
-14
lines changed

4 files changed

+3
-14
lines changed

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java

-6
Original file line numberDiff line numberDiff line change
@@ -468,12 +468,6 @@ public boolean failOnFlowControlLimits() {
468468
return failOnFlowControlLimits;
469469
}
470470

471-
/** Retrieves a snapshot of the publisher current {@link PublisherStats statistics}. */
472-
public PublisherStats getStats() {
473-
// TODO: Implement this.
474-
throw new UnsupportedOperationException();
475-
}
476-
477471
/**
478472
* Schedules immediate publishing of any outstanding messages and waits until all are processed.
479473
*

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherStats.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* Publisher}.
2424
*/
2525
@AutoValue
26-
public abstract class PublisherStats {
26+
abstract class PublisherStats {
2727
/** Number of successfully published messages. */
2828
public abstract long getAckedMessages();
2929

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java

-5
Original file line numberDiff line numberDiff line change
@@ -365,11 +365,6 @@ public void run() {
365365
}
366366
}
367367

368-
public SubscriberStats getStats() {
369-
// TODO: Implement me
370-
return null;
371-
}
372-
373368
/** Subscription which the subscriber is subscribed to. */
374369
public String getSubscription() {
375370
return subscription;

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
* Subscriber}.
2424
*/
2525
@AutoValue
26-
public abstract class SubscriberStats {
27-
26+
abstract class SubscriberStats {
27+
2828
@AutoValue
2929
//TODO: Finish implementation.
3030
public abstract static class Stats {}

0 commit comments

Comments
 (0)