Skip to content

Commit 02a7b13

Browse files
Cleanup: generation instructions, version ordering (#3451)
1 parent 3564371 commit 02a7b13

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

utilities/generate_api.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,15 @@ def run_generate_api(config_path, artifact_type, noisy=False):
122122
print('**** REMAINING MANUAL WORK: *****')
123123
print('This script doesn\'t set up new clients. If this is a new client, you need to:')
124124
print('1. Add the new proto and grpc modules into google-api-grpc/pom.xml')
125+
print('2. Add version declarations for the proto and grpc modules in google-api-grpc/pom.xml')
125126
print('3. Copy an existing client pom.xml to the new client directory, update its text')
126127
print('4. Copy an existing client README.md to the new client directory, update its text')
127128
print('5. Add the new proto, grpc, and client modules into versions.txt')
128129
print('6. Add the new proto, grpc, and client modules into google-cloud-bom/pom.xml')
129-
print('7. Run `utilities/replace_versions.py` to update the module versions')
130+
print('7. Add the API to the list in the root README.md')
131+
print('8. Add the client module into the list in google-cloud-clients/pom.xml')
132+
print('9. Add the stub package for the client into the stubs list in google-cloud-clients/pom.xml')
133+
print('10. Run `utilities/replace_versions.py` to update the module versions')
130134

131135
def main():
132136
parser = argparse.ArgumentParser(description='Regenerate a single API.')

versions.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@ grpc-google-cloud-dialogflow-v2beta1:0.18.0:0.18.1-SNAPSHOT
1818
grpc-google-cloud-dlp-v2:0.18.0:0.18.1-SNAPSHOT
1919
grpc-google-cloud-error-reporting-v1beta1:0.18.0:0.18.1-SNAPSHOT
2020
grpc-google-cloud-firestore-v1beta1:0.18.0:0.18.1-SNAPSHOT
21+
grpc-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
2122
grpc-google-cloud-kms-v1:0.18.0:0.18.1-SNAPSHOT
2223
grpc-google-cloud-language-v1:1.17.0:1.17.1-SNAPSHOT
2324
grpc-google-cloud-language-v1beta2:0.18.0:0.18.1-SNAPSHOT
2425
grpc-google-cloud-logging-v2:0.18.0:0.18.1-SNAPSHOT
2526
grpc-google-cloud-monitoring-v3:1.17.0:1.17.1-SNAPSHOT
2627
grpc-google-cloud-os-login-v1:0.18.0:0.18.1-SNAPSHOT
2728
grpc-google-cloud-pubsub-v1:1.17.0:1.17.1-SNAPSHOT
29+
grpc-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
2830
grpc-google-cloud-spanner-admin-database-v1:0.18.0:0.18.1-SNAPSHOT
2931
grpc-google-cloud-spanner-admin-instance-v1:0.18.0:0.18.1-SNAPSHOT
3032
grpc-google-cloud-spanner-v1:0.18.0:0.18.1-SNAPSHOT
@@ -43,8 +45,6 @@ grpc-google-cloud-video-intelligence-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
4345
grpc-google-cloud-vision-v1:1.17.0:1.17.1-SNAPSHOT
4446
grpc-google-cloud-vision-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
4547
grpc-google-cloud-vision-v1p2beta1:1.17.0:1.17.1-SNAPSHOT
46-
grpc-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
47-
grpc-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
4848
grpc-google-cloud-websecurityscanner-v1alpha:0.18.0:0.18.1-SNAPSHOT
4949
proto-google-cloud-bigquerydatatransfer-v1:0.18.0:0.18.1-SNAPSHOT
5050
proto-google-cloud-bigtable-admin-v2:0.18.0:0.18.1-SNAPSHOT
@@ -57,13 +57,15 @@ proto-google-cloud-dialogflow-v2beta1:0.18.0:0.18.1-SNAPSHOT
5757
proto-google-cloud-dlp-v2:0.18.0:0.18.1-SNAPSHOT
5858
proto-google-cloud-error-reporting-v1beta1:0.18.0:0.18.1-SNAPSHOT
5959
proto-google-cloud-firestore-v1beta1:0.18.0:0.18.1-SNAPSHOT
60+
proto-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
6061
proto-google-cloud-kms-v1:0.18.0:0.18.1-SNAPSHOT
6162
proto-google-cloud-language-v1:1.17.0:1.17.1-SNAPSHOT
6263
proto-google-cloud-language-v1beta2:0.18.0:0.18.1-SNAPSHOT
6364
proto-google-cloud-logging-v2:0.18.0:0.18.1-SNAPSHOT
6465
proto-google-cloud-monitoring-v3:1.17.0:1.17.1-SNAPSHOT
6566
proto-google-cloud-os-login-v1:0.18.0:0.18.1-SNAPSHOT
6667
proto-google-cloud-pubsub-v1:1.17.0:1.17.1-SNAPSHOT
68+
proto-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
6769
proto-google-cloud-spanner-admin-database-v1:0.18.0:0.18.1-SNAPSHOT
6870
proto-google-cloud-spanner-admin-instance-v1:0.18.0:0.18.1-SNAPSHOT
6971
proto-google-cloud-spanner-v1:0.18.0:0.18.1-SNAPSHOT
@@ -82,8 +84,6 @@ proto-google-cloud-video-intelligence-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
8284
proto-google-cloud-vision-v1:1.17.0:1.17.1-SNAPSHOT
8385
proto-google-cloud-vision-v1p1beta1:0.18.0:0.18.1-SNAPSHOT
8486
proto-google-cloud-vision-v1p2beta1:1.17.0:1.17.1-SNAPSHOT
85-
proto-google-cloud-iot-v1:0.18.0:0.18.1-SNAPSHOT
86-
proto-google-cloud-redis-v1beta1:0.18.0:0.18.1-SNAPSHOT
8787
proto-google-cloud-websecurityscanner-v1alpha:0.18.0:0.18.1-SNAPSHOT
8888

8989
#
@@ -116,6 +116,7 @@ google-cloud-dns:0.53.0-alpha:0.53.1-alpha-SNAPSHOT
116116
google-cloud-errorreporting:0.53.0-beta:0.53.1-beta-SNAPSHOT
117117
google-cloud-examples:0.53.0-alpha:0.53.1-alpha-SNAPSHOT
118118
google-cloud-firestore:0.53.0-beta:0.53.1-beta-SNAPSHOT
119+
google-cloud-iot:0.53.0-beta:0.53.1-beta-SNAPSHOT
119120
google-cloud-kms:0.53.0-beta:0.53.1-beta-SNAPSHOT
120121
google-cloud-language:1.35.0:1.35.1-SNAPSHOT
121122
google-cloud-logging:1.35.0:1.35.1-SNAPSHOT
@@ -140,5 +141,4 @@ google-cloud-translate:1.35.0:1.35.1-SNAPSHOT
140141
google-cloud-util:0.53.0-alpha:0.53.1-alpha-SNAPSHOT
141142
google-cloud-video-intelligence:0.53.0-beta:0.53.1-beta-SNAPSHOT
142143
google-cloud-vision:1.35.0:1.35.1-SNAPSHOT
143-
google-cloud-iot:0.53.0-beta:0.53.1-beta-SNAPSHOT
144144
google-cloud-websecurityscanner:0.53.0-alpha:0.53.1-alpha-SNAPSHOT

0 commit comments

Comments
 (0)