Skip to content

Commit 6ef1945

Browse files
authored
fix(bigquery/storage/managedwriter): automatic retry for multiplex test (#8601)
In #8599 we caught a flake related to DeadlineExceeded errors. This class of error is retryable, so we set the EnableWriteRetries option when constructing writers to address this. The DE was likely raised from the service side, as in this case the test ran for ~32s (deadline is 90) and normal execution time should be sub-10s. This is also borne out by the problematic writes, which were both destined for the same table. Fixes: #8599
1 parent e36b9c6 commit 6ef1945

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

bigquery/storage/managedwriter/integration_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -1498,6 +1498,7 @@ func TestIntegration_MultiplexWrites(t *testing.T) {
14981498
WithDestinationTable(TableParentFromParts(testTable.tbl.ProjectID, testTable.tbl.DatasetID, testTable.tbl.TableID)),
14991499
WithType(DefaultStream),
15001500
WithSchemaDescriptor(testTable.dp),
1501+
EnableWriteRetries(true),
15011502
)
15021503
if err != nil {
15031504
t.Fatalf("NewManagedStream %d: %v", k, err)

0 commit comments

Comments
 (0)