Skip to content

remove x-goog-api-client auth header #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arithmetic1728 opened this issue May 30, 2023 · 0 comments · Fixed by #1558
Closed

remove x-goog-api-client auth header #1557

arithmetic1728 opened this issue May 30, 2023 · 0 comments · Fixed by #1558
Assignees
@danielbankhead
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@arithmetic1728
Copy link
Contributor

Please remove the auth lib version from the x-goog-api-client header, per discussion with concord team, this should only be sent for token refresh request, otherwise this will dramatically increase the table size. We will revisit this when we do nodejs auth metrics in the future.

google-auth-library-nodejs/src/transporters.ts

Line 74 in 3563c16

!opts.headers['x-goog-api-client'].includes(authVersion)

@arithmetic1728 arithmetic1728 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 30, 2023
@arithmetic1728 arithmetic1728 mentioned this issue May 30, 2023
Merged
@danielbankhead danielbankhead self-assigned this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove auth lib version from x-goog-api-client header arithmetic1728/google-auth-library-nodejs
2 participants
@danielbankhead @arithmetic1728