fix: make universeDomain private (#1552)

* feat: adds universe_domain field to base external client

* fix: make universeDomain private

* fixing merge issue

Author: aeitzman

src/auth/baseexternalclient.ts

@@ -136,9 +136,9 @@ export abstract class BaseExternalAccountClient extends AuthClient {
   private readonly stsCredential: sts.StsCredentials;
   private readonly clientAuth?: ClientAuthentication;
   private readonly workforcePoolUserProject?: string;
+  private universeDomain?: string;
   public projectId: string | null;
   public projectNumber: string | null;
-  public universeDomain?: string;
   public readonly eagerRefreshThresholdMillis: number;
   public readonly forceRefreshOnFailure: boolean;
   /**

test/test.baseexternalclient.ts

@@ -70,6 +70,7 @@ describe('BaseExternalAccountClient', () => {
     credential_source: {
       file: '/var/run/secrets/goog.id/token',
     },
+    universe_domain: 'universe.domain.com',
   };
   const externalAccountOptionsWithCreds = {
     type: 'external_account',
@@ -283,26 +284,6 @@ describe('BaseExternalAccountClient', () => {
     });
   });
 
-  describe('universeDomain', () => {
-    it('should be undefined if not set', () => {
-      const client = new TestExternalAccountClient(externalAccountOptions);
-
-      assert(client.universeDomain === undefined);
-    });
-
-    it('should be set if provided', () => {
-      const universeDomain = 'universe.domain.com';
-      const options: BaseExternalAccountClientOptions = Object.assign(
-        {},
-        externalAccountOptions
-      );
-      options.universe_domain = universeDomain;
-      const client = new TestExternalAccountClient(options);
-
-      assert.equal(client.universeDomain, universeDomain);
-    });
-  });
-
   describe('getServiceAccountEmail()', () => {
     it('should return the service account email when impersonation is used', () => {
       const saEmail = '[email protected]';