feat: Add relevant attribute descriptions where available #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvanphp
force-pushed
the
add-attribute-description
branch
from
677f715 to
775e5e1
Compare
…s (step 3) (googleapis#6295) Added deprecated props support. Tests are also adjusted.
|
I finished my work on this PR, please have a look. I did not regenerate all the classes yet so it does not get huge for review, but I checked it locally with real It looks like this now:
|
This was referenced Mar 12, 2025
|
My only concern with adding description will be the size of the whole repo, the descriptions are not short and given the number of sub packages in this repo, this will really become problematic as I can see it jumping from 80Mb to 140Mb easily with this change, could you try to generate everything and see how much space it all takes on disk? See: #595 |
|
Yeah, I know the discussion, but the Resources have the full description already, I think that problem needs to be solved anyway, no matter if we add this or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4591
This is already really helpful for Walletobjects API, see the attached screenshot.
I'm still working on adding the Enums as class const, doing great progress.