feat: in googleError:decoreHTTPError handle unknown/custom errors.

Author: miguelvelezsa

gax/src/googleError.ts

@@ -23,7 +23,7 @@ import {JSONValue} from 'proto3-json-serializer';
 
 const protoTypePrefix = 'type.googleapis.com/';
 const resourceInfoType = 'type.googleapis.com/google.rpc.ResourceInfo';
-const defaultResourceTypeNameForUnknownTypes = "Uknown type";
+const defaultResourceTypeNameForUnknownTypes = 'Unknown type';
 
 const numOfPartsInProtoTypeName = 2;
 
@@ -215,33 +215,42 @@ const getErrorDetails = (protobuf: any, json: JSONValue): ErrorDetails => {
   return error_details;
 };
 
-const makeResourceInfoError = (resourceType: string, description: string): JSONValue => {
+const makeResourceInfoError = (
+  resourceType: string,
+  description: string,
+): JSONValue => {
   return {
     '@type': resourceInfoType,
     resourceType,
-    description
-  }
-}
+    description,
+  };
+};
 
-const convertUnknownDetailsToResourceInfoError = (unknownDetails: JSONValue[]) => {
+const convertUnknownDetailsToResourceInfoError = (
+  unknownDetails: JSONValue[],
+) => {
   const unknownDetailsAsResourceInfoError: JSONValue[] = [];
   for (const unknownDetail of unknownDetails) {
     try {
       let resourceType: string = defaultResourceTypeNameForUnknownTypes;
-      if (typeof unknownDetail === 'object' && unknownDetail !== null && '@type' in unknownDetail) {
+      if (
+        typeof unknownDetail === 'object' &&
+        unknownDetail !== null &&
+        '@type' in unknownDetail
+      ) {
         const unknownType: any = unknownDetail['@type'];
         resourceType = unknownType;
       }
       const description = JSON.stringify(unknownDetail);
       unknownDetailsAsResourceInfoError.push(
-        makeResourceInfoError(resourceType, description)
+        makeResourceInfoError(resourceType, description),
       );
     } catch (e) {
       // Failed convert to string, ignore it.
     }
   }
   return unknownDetailsAsResourceInfoError;
-}
+};
 
 export class GoogleErrorDecoder {
   root: protobuf.Root;
@@ -354,8 +363,9 @@ export class GoogleErrorDecoder {
         details = errorDetails.knownDetails;
       }
       if (errorDetails.unknownDetails.length) {
-        const unknowDetailsAsResourceInfo = convertUnknownDetailsToResourceInfoError(errorDetails.unknownDetails);
-        details = [...details, ...unknowDetailsAsResourceInfo];  
+        const unknowDetailsAsResourceInfo =
+          convertUnknownDetailsToResourceInfoError(errorDetails.unknownDetails);
+        details = [...details, ...unknowDetailsAsResourceInfo];
       }
       if (details.length) {
         json.details = details;

gax/test/unit/googleError.ts

@@ -471,11 +471,9 @@ describe('http error decoding return resource info for unknown proto-error', ()
       error.statusDetails?.length,
       json['error']['details'].length,
     );
-    assert.deepEqual(error.statusDetails[0],
-      {
-        resourceType: 'type.googleapis.com/Custom',
-        description: JSON.stringify(custom),
-      }
-    )
+    assert.deepEqual(error.statusDetails[0], {
+      resourceType: 'type.googleapis.com/Custom',
+      description: JSON.stringify(custom),
+    });
   });
 });