Skip to content

Allow an API endpoint to be explicitly passed #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukesneeringer opened this issue Aug 14, 2017 · 4 comments
Closed

Allow an API endpoint to be explicitly passed #408

lukesneeringer opened this issue Aug 14, 2017 · 4 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@lukesneeringer
Copy link
Contributor

We currently hardcode api-name.googleapis.com in the Node.js API clients. We should take an options.apiEndpoint that allows the user to override this. This is useful for API producers wanting to use staging servers, customers wanting to test with emulators, etc.

See googleapis/google-cloud-node#1630 (comment)

@evaogbe
Copy link

evaogbe commented Aug 16, 2017

@lukesneeringer Can you add a priority to this?

@evaogbe
Copy link

evaogbe commented Aug 26, 2017

Isn't this already covered in the serviceAddress option?

@evaogbe
Copy link

evaogbe commented Nov 29, 2017

@lukesneeringer @alexander-fenster Is this still relevant?

@yihanzhen yihanzhen transferred this issue from googleapis/gapic-generator Apr 9, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 9, 2020
@alexander-fenster
Copy link
Contributor

We use an option from an annotation, and we let the user override it in the client constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

5 participants