Skip to content

Commit e990105

Browse files
authored
fix: fix broken Gradle allJars task on generated libs (#901)
1 parent 8fa2660 commit e990105

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.github/workflows/ci.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
mkdir /tmp/java-storage
5353
tar zxvf bazel-bin/test/integration/google-cloud-storage-v2-java.tar.gz -C /tmp/java-storage
5454
pushd /tmp/java-storage/google-cloud-storage-v2-java
55-
./gradlew clean build publishToMavenLocal
55+
./gradlew clean build publishToMavenLocal sourcesJar allJars
5656
popd
5757
5858
- name: Gradle Build Generated Compute Client Library
@@ -62,7 +62,7 @@ jobs:
6262
bazel --batch build @com_google_googleapis//google/cloud/compute/v1small:google-cloud-compute-small-v1-java
6363
tar zxvf bazel-bin/external/com_google_googleapis/google/cloud/compute/v1small/google-cloud-compute-small-v1-java.tar.gz -C /tmp/java-compute
6464
pushd /tmp/java-compute/google-cloud-compute-small-v1-java
65-
./gradlew clean build publishToMavenLocal
65+
./gradlew clean build publishToMavenLocal sourcesJar allJars
6666
popd
6767
6868
- uses: actions/upload-artifact@v2

rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@ clean {
4040
task allJars(type: Copy) {
4141
dependsOn test, jar
4242
into 'all-jars'
43-
// Replace with `from configurations.testRuntimeOnly, jar` to include test dependencies
44-
from configurations.runtimeOnly, jar
43+
// Replace with `from configurations.testRuntimeClasspath, jar` to include test dependencies
44+
from configurations.runtimeClasspath, jar
4545
}

rules_java_gapic/resources/gradle/client_grpcrest.gradle.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,6 @@ clean {
4242
task allJars(type: Copy) {
4343
dependsOn test, jar
4444
into 'all-jars'
45-
// Replace with `from configurations.testRuntimeOnly, jar` to include test dependencies
46-
from configurations.runtimeOnly, jar
45+
// Replace with `from configurations.testRuntimeClasspath, jar` to include test dependencies
46+
from configurations.runtimeClasspath, jar
4747
}

rules_java_gapic/resources/gradle/client_rest.gradle.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@ clean {
3737
task allJars(type: Copy) {
3838
dependsOn test, jar
3939
into 'all-jars'
40-
// Replace with `from configurations.testRuntimeOnly, jar` to include test dependencies
41-
from configurations.runtimeOnly, jar
40+
// Replace with `from configurations.testRuntimeClasspath, jar` to include test dependencies
41+
from configurations.runtimeClasspath, jar
4242
}

0 commit comments

Comments
 (0)