Skip to content

Commit ae17e7e

Browse files
authored
chore: DIREGAPIC #2 refactoring of the rest Composer Classes (#730)
1 parent 5d182dd commit ae17e7e

File tree

96 files changed

+2504
-2379
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

96 files changed

+2504
-2379
lines changed

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
echo "The old one will disappear after 7 days."
4747
4848
- name: Unit Tests
49-
run: bazel --batch test $(bazel query "//src/test/..." | grep "Test$") --noshow_progress
49+
run: bazel --batch test $(bazel query "//src/test/..." | grep "Test$") --noshow_progress --test_output=errors
5050

5151
- name: Integration Tests
5252
run: bazel --batch test //test/integration:asset //test/integration:credentials //test/integration:iam //test/integration:kms //test/integration:logging //test/integration:redis //test/integration:library --noshow_progress

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
### [1.0.6](https://www.github.com/googleapis/gapic-generator-java/compare/v1.0.5...v1.0.6) (2021-05-19)
4+
5+
6+
### Bug Fixes
7+
8+
* **mixins:** Gate mixin RPC on HTTP rules, add yaml doc/http overrides ([#727](https://www.github.com/googleapis/gapic-generator-java/issues/727)) ([229da5d](https://www.github.com/googleapis/gapic-generator-java/commit/229da5d94cf7db060abf3ea006a20d1ade804597))
9+
310
### [1.0.5](https://www.github.com/googleapis/gapic-generator-java/compare/v1.0.4...v1.0.5) (2021-05-17)
411

512

dependencies.properties

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ version.com_google_protobuf=3.13.0
1111
# Version of google-java-format is downgraded from 1.8 to 1.7, because 1.8 supports java 11 minimum, while our JRE is java 8.
1212
version.google_java_format=1.7
1313
version.com_google_api_common_java=1.9.3
14-
# TODO(miraleung): Update this.
1514
version.com_google_gax_java=1.62.0
1615
version.io_grpc_java=1.30.2
1716

1817
# Common deps.
19-
maven.com_google_guava_guava=com.google.guava:guava:26.0-jre
18+
maven.com_google_guava_guava=com.google.guava:guava:30.1-android
2019
maven.com_google_code_findbugs_jsr305=com.google.code.findbugs:jsr305:3.0.0
2120
maven.com_google_auto_value_auto_value=com.google.auto.value:auto-value:1.7.2
2221
maven.com_google_auto_value_auto_value_annotations=com.google.auto.value:auto-value-annotations:1.7.2

src/main/java/com/google/api/generator/gapic/composer/ClassComposer.java

-18
This file was deleted.

src/main/java/com/google/api/generator/gapic/composer/Composer.java

+8
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,15 @@
1717
import com.google.api.generator.engine.ast.ClassDefinition;
1818
import com.google.api.generator.engine.ast.ScopeNode;
1919
import com.google.api.generator.gapic.composer.comment.CommentComposer;
20+
import com.google.api.generator.gapic.composer.common.ServiceClientClassComposer;
21+
import com.google.api.generator.gapic.composer.common.ServiceStubClassComposer;
22+
import com.google.api.generator.gapic.composer.grpc.GrpcServiceCallableFactoryClassComposer;
23+
import com.google.api.generator.gapic.composer.grpc.GrpcServiceStubClassComposer;
24+
import com.google.api.generator.gapic.composer.grpc.MockServiceClassComposer;
25+
import com.google.api.generator.gapic.composer.grpc.MockServiceImplClassComposer;
26+
import com.google.api.generator.gapic.composer.grpc.ServiceClientTestClassComposer;
2027
import com.google.api.generator.gapic.composer.grpc.ServiceSettingsClassComposer;
28+
import com.google.api.generator.gapic.composer.grpc.ServiceStubSettingsClassComposer;
2129
import com.google.api.generator.gapic.composer.resourcename.ResourceNameHelperClassComposer;
2230
import com.google.api.generator.gapic.model.GapicClass;
2331
import com.google.api.generator.gapic.model.GapicClass.Kind;

src/main/java/com/google/api/generator/gapic/composer/comment/StubCommentComposer.java

-16
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,12 @@ public class StubCommentComposer {
3131
private static final String ADVANCED_USAGE_API_REFLECTION_DESCRIPTION =
3232
"This class is for advanced usage and reflects the underlying API directly.";
3333

34-
// TODO: remove after Pre-DIREGAPIC refactoring is fully merged
35-
private static final StubCommentComposer GRPC_INSTANCE = new StubCommentComposer("gRPC");
36-
3734
private final String transportPrefix;
3835

3936
public StubCommentComposer(String transportPrefix) {
4037
this.transportPrefix = transportPrefix;
4138
}
4239

43-
// TODO: remove after Pre-DIREGAPIC refactoring is fully merged
44-
public static List<CommentStatement> createGrpcServiceStubClassHeaderComments(
45-
String serviceName, boolean isDeprecated) {
46-
return GRPC_INSTANCE.createTransportServiceStubClassHeaderComments(serviceName, isDeprecated);
47-
}
48-
4940
public List<CommentStatement> createTransportServiceStubClassHeaderComments(
5041
String serviceName, boolean isDeprecated) {
5142
JavaDocComment.Builder javaDocBuilder = JavaDocComment.builder();
@@ -63,13 +54,6 @@ public List<CommentStatement> createTransportServiceStubClassHeaderComments(
6354
.build()));
6455
}
6556

66-
// TODO: remove after Pre-DIREGAPIC refactoring is fully merged
67-
public static List<CommentStatement> createGrpcServiceCallableFactoryClassHeaderComments(
68-
String serviceName, boolean isDeprecated) {
69-
return GRPC_INSTANCE.createTransportServiceCallableFactoryClassHeaderComments(
70-
serviceName, isDeprecated);
71-
}
72-
7357
public List<CommentStatement> createTransportServiceCallableFactoryClassHeaderComments(
7458
String serviceName, boolean isDeprecated) {
7559
JavaDocComment.Builder javaDocBuilder = JavaDocComment.builder();

0 commit comments

Comments
 (0)