-
Notifications
You must be signed in to change notification settings - Fork 1.3k
syzbot: fix ci-upstream-kasan-badwrites-root #5767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Manager ignores are matched against kernel console output. So I suspect the "KASAN:.*Read" ignore we have is not working, since these things are on separate lines:
So I think the 1 unique write we got is unrelated. But we shouldn't fix it as is as well, b/c we shouldn't produce dups by reporting same repro as 2 different KASAN bugs while trying to find KASAN writes. |
From a high-level view, the fact it's the only instance with KASAN: slab-out-of-bounds Write in hfs_bnode_read + several other unique found would indicate we should keep whatever it is contributing. Sure, the intended result was not realized (dozens of KASAN write reports found, see Dmitry's comment above), but it did help contribute to find more unique bugs. Would we be able to realize the same results by donating/moving the KASAN write VM resources to the normal KASAN instance(s)? |
I think we can remove it now, it's not doing what it's supposed to be doing, and we don't plan to fix it. |
Describe the bug
We have a kasan-write focused instance.
It reported only 1 kasan write. https://syzkaller.appspot.com/upstream?only_manager=ci-upstream-kasan-badwrites-root
There are no fixed kasan writes found only on this manager. https://syzkaller.appspot.com/upstream/fixed?only_manager=ci-upstream-kasan-badwrites-root.
The goal was to find more
KASAN: write
bugs.The reality - we have only 1
KASAN: write
but reported ~20 unique bugs.Is it a success or fail?
The options I see:
The text was updated successfully, but these errors were encountered: