Skip to content

Display RRM module name in permission error banner when OAuth is missing #10797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
zutigrm opened this issue May 19, 2025 · 0 comments
Open
1 task
Labels
Type: Enhancement Improvement of an existing feature

Comments

@zutigrm
Copy link
Collaborator

zutigrm commented May 19, 2025

Feature Description

When we start setup for Analytics and then cancel it/go back from OAuth screen, we get setup error with mention of the module name (working fine):

Image

⚠ But when we do the same for RRM module, we get generic message:

Image

Even the unsatisfied scope seems to be pretty easy to associate with the module: https://www.googleapis.com/auth/subscribewithgoogle.publications.readonly

We can probably update assets/js/components/notifications/UnsatisfiedScopesAlert/utils.js mapScopesToModuleNames function to map publications to the RRM module. This one is probably minor one, but we can still give it a slight improvement


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@zutigrm zutigrm added the Type: Enhancement Improvement of an existing feature label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant