Skip to content

Improve the resilience of the Backstop Docker image build #10791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
techanvil opened this issue May 19, 2025 · 2 comments
Open
1 task

Improve the resilience of the Backstop Docker image build #10791

techanvil opened this issue May 19, 2025 · 2 comments
Labels
P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling

Comments

@techanvil
Copy link
Collaborator

techanvil commented May 19, 2025

Feature Description

As discussed here, #10788 (comment), we should update the Backstop Dockerfile to help avoid our Chromium version going out of sync again. We should also take the opportunity to further refine the Dockerfile, and to avoid the need to force the build on each run as discussed in the linked comment.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The Backstop Dockerfile should be updated as follows:

  • The version of Chromium should be installed in a way that doesn't depend on the version in the APT repository, so as to avoid the image build failing unexpectedly with future repository updates.
  • The image tag should include a version to ensure it's fully rebuilt when changes are made, helping to avoid hard to spot caching issues (e.g. the apt-get update stage is cached but could result in different build outputs).
  • The RUN commands should be consolidated where it makes sense to do so.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@techanvil techanvil self-assigned this May 19, 2025
@techanvil techanvil removed their assignment May 19, 2025
@techanvil techanvil added P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling labels May 19, 2025
@benbowler
Copy link
Collaborator

benbowler commented May 22, 2025

FYI #10486 exists to use a built version of the image which will help keep this consistent between runs as the dependencies will be set at build time and only updated when the image is rebuilt and published.

@techanvil
Copy link
Collaborator Author

Thanks @benbowler, that's a good point. I think the AC for this issue remain valid even taking that into account, but it's useful to highlight the link between the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

2 participants