Add missing googlesitekit-notifications dependency to module assets

[techanvil]

Feature Description

As discussed here, #10269 (comment), we are currently missing the googlesitekit-notifications dependency for most module assets. This is not causing any problems at present, but we should ensure that the assets have the full list of dependencies to avoid potential issues in future.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The googlesitekit-notifications asset should be added as a dependency for the module assets for the following modules:
  • Ads
  • AdSense
  • Analytics 4
  • PageSpeed Insights
  • Sign in With Google

Implementation Brief

• Add googlesitekit-notifications to the dependencies for each of the following Script assets:

site-kit-wp/includes/Modules/Ads.php

Lines 151 to 165 in fd1f309

	new Script(
	'googlesitekit-modules-ads',
	array(
	'src' => $base_url . 'js/googlesitekit-modules-ads.js',
	'dependencies' => array(
	'googlesitekit-vendor',
	'googlesitekit-api',
	'googlesitekit-data',
	'googlesitekit-modules',
	'googlesitekit-datastore-site',
	'googlesitekit-datastore-user',
	'googlesitekit-components',
	),
	)
	),

site-kit-wp/includes/Modules/AdSense.php

Lines 798 to 812 in fd1f309

	new Script(
	'googlesitekit-modules-adsense',
	array(
	'src' => $base_url . 'js/googlesitekit-modules-adsense.js',
	'dependencies' => array(
	'googlesitekit-vendor',
	'googlesitekit-api',
	'googlesitekit-data',
	'googlesitekit-modules',
	'googlesitekit-datastore-site',
	'googlesitekit-datastore-user',
	'googlesitekit-components',
	),
	)
	),

site-kit-wp/includes/Modules/Analytics_4.php

Lines 2017 to 2032 in fd1f309

	new Script(
	'googlesitekit-modules-analytics-4',
	array(
	'src' => $base_url . 'js/googlesitekit-modules-analytics-4.js',
	'dependencies' => array(
	'googlesitekit-vendor',
	'googlesitekit-api',
	'googlesitekit-data',
	'googlesitekit-modules',
	'googlesitekit-datastore-site',
	'googlesitekit-datastore-user',
	'googlesitekit-datastore-forms',
	'googlesitekit-components',
	'googlesitekit-modules-data',
	),
	)

site-kit-wp/includes/Modules/Analytics_4.php

Lines 2017 to 2032 in fd1f309

	new Script(
	'googlesitekit-modules-analytics-4',
	array(
	'src' => $base_url . 'js/googlesitekit-modules-analytics-4.js',
	'dependencies' => array(
	'googlesitekit-vendor',
	'googlesitekit-api',
	'googlesitekit-data',
	'googlesitekit-modules',
	'googlesitekit-datastore-site',
	'googlesitekit-datastore-user',
	'googlesitekit-datastore-forms',
	'googlesitekit-components',
	'googlesitekit-modules-data',
	),
	)

site-kit-wp/includes/Modules/PageSpeed_Insights.php

Lines 153 to 165 in fd1f309

	new Script(
	'googlesitekit-modules-pagespeed-insights',
	array(
	'src' => $base_url . 'js/googlesitekit-modules-pagespeed-insights.js',
	'dependencies' => array(
	'googlesitekit-vendor',
	'googlesitekit-api',
	'googlesitekit-data',
	'googlesitekit-modules',
	'googlesitekit-datastore-site',
	'googlesitekit-components',
	),
	)

site-kit-wp/includes/Modules/Sign_In_With_Google.php

Lines 296 to 307 in fd1f309

	array(
	'src' => $this->context->url( 'dist/assets/js/googlesitekit-modules-sign-in-with-google.js' ),
	'dependencies' => array(
	'googlesitekit-vendor',
	'googlesitekit-api',
	'googlesitekit-data',
	'googlesitekit-modules',
	'googlesitekit-datastore-site',
	'googlesitekit-datastore-user',
	'googlesitekit-components',
	),
	)

Test Coverage

• Fix any breaking tests.
• No additional test coverage needed.

QABrief

• No QA is required in this issue because engineer will confirm that googlesitekit-notifications is added as dependency for module assets.

Changelog entry

• N/A

[eugene-manuilov]

IB ✔, but the estimate is too high, i'll reduce it to 3 since it is "one-line change" type of things which is technically is 1.

[aaemnnosttv]

No QA needed, moving to approval