Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filegroup for referencing common mlir files in tests/Examples #1661

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented Apr 4, 2025

Fixes #1659

@j2kun j2kun requested a review from ZenithalHourlyRate April 4, 2025 17:36
@j2kun j2kun force-pushed the filegroup branch 4 times, most recently from 010b739 to bee267b Compare April 4, 2025 18:13
@j2kun j2kun added pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing and removed pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing labels Apr 5, 2025
@j2kun
Copy link
Collaborator Author

j2kun commented Apr 6, 2025

Turns out we don't even need the filegroup or data attribute, and can do this just using exports_files on the source directory. Internal google linters made me change it, so the PR will land with that change not reflected here.

@copybara-service copybara-service bot merged commit d7156c9 into google:main Apr 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use filegroups for common mlir across tests
2 participants