-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFV noise bound ever-so-slightly underestimating on one test case #1614
Comments
I suspect this will fail now and then...it do is a probablisitic (assumed to be 99.99%) bound but it should not fail that frequently. The problem should be with the underlying noise model or my implementation, but as far as I can tell there are quite a few questionable parts in every noise analysis (also implementation choices) so I think making them work completely should still be an undergoing research topic. |
In that test, maybe we can avoid this by just removing one of the operations so it's 15 instead of 16? |
No, the error happens at the first multiplication so no matter how many ct there are it is probable to error again, so I disabled all 8,16,32 test in the PR. |
What if we add a pass option for validation, that does something like count of operations that failed noise validation, and only err if that count exceeds a value given in the pass flag. This would only be used for testing purposes. |
Note Re-commenting because this issue was closed with unresolved TODOs. This issue has 1 outstanding TODOs:
This comment was autogenerated by todo-backlinks |
See https://github.com/google/heir/actions/runs/14040657498/job/39309761604
The text was updated successfully, but these errors were encountered: