Skip to content

Commit 329372b

Browse files
authored
Fixing grpcio dependency behavior in devenv GRR container.
grpcio and grpcio-tools are effectively build-only dependency for GRR, but a runtime dependency for google-cloud-pubsub. To avoid versioning conflicts, we should install our own packages with separate `pip install` calls - this allows each call to override the version of grpcio or grpcio-tools if needed. This is clearly a hack. A proper fix is to migrate from setup.py to toml files and explicitly declare grpcio and grpcio-tools as GRR's build (and not runtime) dependencies.
1 parent 7cf5a07 commit 329372b

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

devenv/src/containers/grr/Containerfile

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,10 @@ RUN cd /grr/persist \
2323

2424
RUN cd /grr/src \
2525
&& . /grr/persist/venv/bin/activate \
26-
&& pip install \
27-
-e grr/proto \
28-
-e grr/core \
29-
-e grr/client \
30-
-e grr/client_builder \
31-
-e api_client/python \
32-
-e grr/server \
33-
-e grr/test
26+
&& pip install -e grr/proto \
27+
&& pip install -e grr/core \
28+
&& pip install -e grr/client \
29+
&& pip install -e grr/client_builder \
30+
&& pip install -e api_client/python \
31+
&& pip install -e grr/server \
32+
&& pip install -e grr/test

0 commit comments

Comments
 (0)