Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Use Terraform to manage our alerting rules #461

Closed
yegle opened this issue Sep 2, 2020 · 6 comments
Closed

Use Terraform to manage our alerting rules #461

yegle opened this issue Sep 2, 2020 · 6 comments
Assignees
@yegle
Labels
kind/enhancement New feature or feature request.

Comments

@yegle
Copy link
Contributor

yegle commented Sep 2, 2020

TL;DR

Similar to #460, we should also manage our alerting rules using Terraform so that the work can be replicated easily.

Design

Use https://www.terraform.io/docs/providers/google/r/monitoring_alert_policy.html to manage alerting policies in StackDriver.
@yegle
Copy link
Contributor Author

yegle commented Sep 2, 2020

/assign @yegle

@sethvargo
Copy link
Member

alerting policies in StackDriver.

alerting policies in the product formerly known as StackDriver.

@icco
Copy link
Contributor

icco commented Sep 3, 2020

/kind enhancement

@google-oss-robot google-oss-robot added the kind/enhancement New feature or feature request. label Sep 3, 2020
@icco icco mentioned this issue Sep 3, 2020
Merged
@icco
Copy link
Contributor

icco commented Sep 10, 2020

There are two alerts we should write:

  • Elevated 5xx
  • Elevated rate limited requests

I've got the 5xx if you want to write the rate limit one @yegle ?

@icco icco mentioned this issue Sep 10, 2020
Merged
@yegle
Copy link
Contributor Author

yegle commented Sep 10, 2020

Sure I can take the rate limit requests one.

@yegle
Copy link
Contributor Author

yegle commented Sep 14, 2020

Consider this fixed.

@yegle yegle closed this as completed Sep 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yegle yegle

Labels
kind/enhancement New feature or feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@icco @yegle @sethvargo @google-oss-robot