Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Show history of issued codes with status #232

Closed
whaught opened this issue Aug 14, 2020 · 6 comments · Fixed by #784
Closed

Show history of issued codes with status #232

whaught opened this issue Aug 14, 2020 · 6 comments · Fixed by #784
Assignees
Labels
kind/enhancement New feature or feature request.

Comments

@whaught
Copy link
Contributor

whaught commented Aug 14, 2020

TL;DR

Create a page where a user or realm admin can see a list of recently issued codes.

Design

Proposal

  • Create a List API for codes.

    • Users get the codes they've issued themselves
    • Realm Admins see all codes
    • Consider pagination and limits
  • The original mock calls for showing the

    • test result
    • code
    • expiry
    • anonymized phone (***) ***-**31
      • Note: no. nothing to identify. just uuid.
    • Invalidate code button?

Note: one problem with this (and why we have uuid) is that not all systems will use phone# and may require the user to reach out manually. We don't have any other associated data on who the patient is which makes it tough for the user to know who the code is intended for and follow-up if unclaimed. The uuid allows this or alternative clients to keep such data locally.

Alternatives considered

I've created #227 where a user can check a single-id at a time. This, however, requires the user to keep a list of their issued UUIDs which may be less useful (the API is possible more useful programmatically rather than as UX) but allows the user to track the private patient data locally and separately. The history table could replace this if its exhaustive.

@whaught
Copy link
Contributor Author

whaught commented Aug 14, 2020

/assign

@mikehelmick mikehelmick added this to the v0.5.0 milestone Aug 18, 2020
@icco
Copy link
Contributor

icco commented Aug 19, 2020

/kind enhancement

@google-oss-robot google-oss-robot added the kind/enhancement New feature or feature request. label Aug 19, 2020
@whaught
Copy link
Contributor Author

whaught commented Aug 19, 2020

Note: We've since decided to hash the codes. That may make this less useful

@mikehelmick
Copy link
Contributor

Would it make sense to show the UUIDs instead?

It would for someone doing an external integration, because they could tie that back into the CRM

@sethvargo
Copy link
Member

If the use case is external integration, it seems like an API might be more appropriate?

@mikehelmick
Copy link
Contributor

both - in general, things we put in the UI should probably also have APIs

@sethvargo sethvargo removed this from the v0.5.0 milestone Sep 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants