Add appstore url to mobile apps. (#738)

Author: jeremyfaller

cmd/server/assets/mobileapps/_app.html

@@ -9,6 +9,13 @@
   {{template "errorable" $app.ErrorsFor "name"}}
 </div>
 
+<div class="form-label-group">
+  <input type="text" name="url" id="url" class="form-control{{if $app.ErrorsFor "url"}} is-invalid{{end}}" value="{{$app.URL}}"
+    placeholder="AppStore URL" autofocus>
+  <label for="name">AppStore URL</label>
+  {{template "errorable" $app.ErrorsFor "url"}}
+</div>
+
 <div class="form-group">
   <select name="os" id="os" class="form-control custom-select{{if $app.ErrorsFor "os"}} is-invalid{{end}}">
     <option selected disabled>Choose platform...</option>

cmd/server/assets/mobileapps/show.html

@@ -30,6 +30,9 @@ <h1>{{$app.Name}}</h1>
           <dt>App name</dt>
           <dd>{{$app.Name}}</dd>
 
+          <dt>AppStore link</dt>
+          <dd><a href="{{$app.URL}}" target="_blank">{{$app.URL}}</a></dd>
+
           <dt>OS</dt>
           <dd>
             {{if (eq $app.OS .iOS)}}

pkg/controller/mobileapps/create.go

@@ -26,6 +26,7 @@ import (
 func (c *Controller) HandleCreate() http.Handler {
 	type FormData struct {
 		Name  string          `form:"name"`
+		URL   string          `form:"url"`
 		OS    database.OSType `form:"os"`
 		AppID string          `form:"app_id"`
 		SHA   string          `form:"sha"`
@@ -64,6 +65,7 @@ func (c *Controller) HandleCreate() http.Handler {
 		if err := controller.BindForm(w, r, &form); err != nil {
 			app := &database.MobileApp{
 				Name:  form.Name,
+				URL:   form.URL,
 				OS:    form.OS,
 				AppID: form.AppID,
 				SHA:   form.SHA,
@@ -78,6 +80,7 @@ func (c *Controller) HandleCreate() http.Handler {
 		app := &database.MobileApp{
 			Name:    form.Name,
 			RealmID: realm.ID,
+			URL:     form.URL,
 			OS:      form.OS,
 			AppID:   form.AppID,
 			SHA:     form.SHA,

pkg/controller/mobileapps/update.go

@@ -28,6 +28,7 @@ import (
 func (c *Controller) HandleUpdate() http.Handler {
 	type FormData struct {
 		Name  string          `form:"name"`
+		URL   string          `form:"url"`
 		OS    database.OSType `form:"os"`
 		AppID string          `form:"app_id"`
 		SHA   string          `form:"sha"`
@@ -89,6 +90,7 @@ func (c *Controller) HandleUpdate() http.Handler {
 
 		// Build the authorized app struct
 		app.Name = form.Name
+		app.URL = form.URL
 		app.OS = form.OS
 		app.AppID = form.AppID
 		app.SHA = form.SHA

pkg/database/migrations.go

@@ -1427,6 +1427,15 @@ func (db *Database) getMigrations(ctx context.Context) *gormigrate.Gormigrate {
 				return tx.Exec("ALTER TABLE realms DROP COLUMN IF EXISTS mfa_required_grace_period").Error
 			},
 		},
+		{
+			ID: "00058-AddAppStoreLink",
+			Migrate: func(tx *gorm.DB) error {
+				return tx.Exec("ALTER TABLE mobile_apps ADD COLUMN IF NOT EXISTS url TEXT").Error
+			},
+			Rollback: func(tx *gorm.DB) error {
+				return tx.Exec("ALTER TABLE realms DROP COLUMN IF EXISTS url").Error
+			},
+		},
 	})
 }
 

pkg/database/mobile_app.go

@@ -57,6 +57,10 @@ type MobileApp struct {
 	// RealmID is the id of the mobile app.
 	RealmID uint `gorm:"column:realm_id;"`
 
+	// URL is the link to the app in it's appstore.
+	URL    string  `gorm:"-"`
+	URLPtr *string `gorm:"column:url; type:text"`
+
 	// OS is the type of the application we're using (eg, iOS, Android).
 	OS OSType `gorm:"column:os; type:int;"`
 
@@ -84,6 +88,12 @@ func (a *MobileApp) BeforeSave(tx *gorm.DB) error {
 		a.AddError("app_id", "is required")
 	}
 
+	a.URL = strings.TrimSpace(a.URL)
+	a.URLPtr = stringPtr(a.URL)
+	if a.URL == "" {
+		a.AddError("url", "is required")
+	}
+
 	// Ensure OS is valid
 	if a.OS < OSTypeIOS || a.OS > OSTypeAndroid {
 		a.AddError("os", "is invalid")
@@ -225,6 +235,11 @@ func (a *MobileApp) AuditDisplay() string {
 	return fmt.Sprintf("%s (%s)", a.Name, a.OS.Display())
 }
 
+func (a *MobileApp) AfterFind(tx *gorm.DB) error {
+	a.URL = stringValue(a.URLPtr)
+	return nil
+}
+
 // PurgeMobileApps will delete mobile apps that have been deleted for more than
 // the specified time.
 func (db *Database) PurgeMobileApps(maxAge time.Duration) (int64, error) {

tools/seed/main.go

@@ -172,12 +172,14 @@ func realMain(ctx context.Context) error {
 		{
 			Name:    "Example iOS app",
 			RealmID: realm1.ID,
+			URL:     "http://apple.com",
 			OS:      database.OSTypeIOS,
 			AppID:   "ios.example.app",
 		},
 		{
 			Name:    "Example Android app",
 			RealmID: realm1.ID,
+			URL:     "http://google.com",
 			OS:      database.OSTypeAndroid,
 			AppID:   "android.example.app",
 			SHA:     "AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA",