GitHub PR#160 Refactor NonReversibleValidationException pkg

--
9de1cfc by ignite1771 <[email protected]>:

Categorize it into exception package and solve related
build dependencies.

Closes #160
Change-Id: I72d8cdfbffa031c2941e8532d2a50baca7264408
PiperOrigin-RevId: 374244608

Author: ignite1771

java/com/google/copybara/BUILD

@@ -99,7 +99,6 @@ BASE_SRCS = [
     "LocalParallelizer.java",
     "Metadata.java",
     "MigrationInfo.java",
-    "NonReversibleValidationException.java",
     "Option.java",
     "Options.java",
     "Origin.java",

java/com/google/copybara/Core.java

@@ -37,6 +37,7 @@
 import com.google.copybara.doc.annotations.Example;
 import com.google.copybara.doc.annotations.UsesFlags;
 import com.google.copybara.exception.EmptyChangeException;
+import com.google.copybara.exception.NonReversibleValidationException;
 import com.google.copybara.feedback.Feedback;
 import com.google.copybara.folder.FolderModule;
 import com.google.copybara.templatetoken.Parser;

java/com/google/copybara/MapMapper.java

@@ -19,6 +19,7 @@
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableBiMap;
 import com.google.common.collect.ImmutableMap;
+import com.google.copybara.exception.NonReversibleValidationException;
 import com.google.copybara.transform.ReversibleFunction;
 
 public class MapMapper implements ReversibleFunction<String, String> {

java/com/google/copybara/Transformation.java

@@ -16,6 +16,7 @@
 
 package com.google.copybara;
 
+import com.google.copybara.exception.NonReversibleValidationException;
 import com.google.copybara.exception.RepoException;
 import com.google.copybara.exception.ValidationException;
 import java.io.IOException;

java/com/google/copybara/buildozer/BuildozerBatch.java

@@ -19,12 +19,12 @@
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterables;
-import com.google.copybara.NonReversibleValidationException;
 import com.google.copybara.TransformWork;
 import com.google.copybara.Transformation;
 import com.google.copybara.WorkflowOptions;
-import com.google.copybara.exception.ValidationException;
 import com.google.copybara.buildozer.BuildozerOptions.BuildozerCommand;
+import com.google.copybara.exception.NonReversibleValidationException;
+import com.google.copybara.exception.ValidationException;
 import java.io.IOException;
 
 /**

java/com/google/copybara/buildozer/BuildozerDelete.java

@@ -20,11 +20,11 @@
 
 import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableList;
-import com.google.copybara.NonReversibleValidationException;
 import com.google.copybara.TransformWork;
 import com.google.copybara.Transformation;
 import com.google.copybara.WorkflowOptions;
 import com.google.copybara.buildozer.BuildozerOptions.BuildozerCommand;
+import com.google.copybara.exception.NonReversibleValidationException;
 import com.google.copybara.exception.ValidationException;
 import java.io.IOException;
 import javax.annotation.Nullable;

java/com/google/copybara/buildozer/BuildozerModify.java

@@ -20,11 +20,11 @@
 
 import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableList;
-import com.google.copybara.NonReversibleValidationException;
 import com.google.copybara.TransformWork;
 import com.google.copybara.Transformation;
 import com.google.copybara.WorkflowOptions;
 import com.google.copybara.buildozer.BuildozerOptions.BuildozerCommand;
+import com.google.copybara.exception.NonReversibleValidationException;
 import com.google.copybara.exception.ValidationException;
 import com.google.copybara.util.console.Console;
 import java.io.IOException;

java/com/google/copybara/buildozer/Command.java

@@ -21,7 +21,7 @@
 import com.google.common.base.Joiner;
 import com.google.common.base.Preconditions;
 import com.google.common.base.Splitter;
-import com.google.copybara.NonReversibleValidationException;
+import com.google.copybara.exception.NonReversibleValidationException;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;

java/com/google/copybara/exception/BUILD

@@ -28,5 +28,8 @@ java_library(
         ["**/*.java"],
     ),
     javacopts = JAVACOPTS,
-    deps = ["//third_party:error_prone"],
+    deps = [
+        "//third_party:error_prone",
+        "//third_party:starlark",
+    ],
 )

java/com/google/copybara/NonReversibleValidationException.java renamed to java/com/google/copybara/exception/NonReversibleValidationException.java

@@ -14,15 +14,13 @@
  * limitations under the License.
  */
 
-package com.google.copybara;
+package com.google.copybara.exception;
 
 import net.starlark.java.eval.EvalException;
 
 /**
- * Exception thrown when a {@link Transformation} is not reversible but the configuration asked for
- * the reverse.
- *
- * TODO(malcon): Move to the exception package
+ * Exception thrown when a {@link com.google.copybara.Transformation} is not reversible
+ * but the configuration asked for the reverse.
  */
 public class NonReversibleValidationException extends EvalException {