Skip to content

Commit 81aec73

Browse files
meringmikelalcon
authored andcommitted
Improve Dockerfile FROM
- Fix to actually using argument in ci.Dockerfile - Unify the format in ci.Dockerfile and Dockerfile - The new format allows referring to an image by SHA instead of tag. The format to refer to a image by SHA starts with "@sha256:" instead of ":". Change-Id: If64e0197ae9196bbc52e99098ab29c6ce8284411
1 parent 898ee70 commit 81aec73

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
ARG BAZEL_VERSION=6.0.0
16-
FROM gcr.io/bazel-public/bazel:${BAZEL_VERSION} AS build
15+
ARG BAZEL_VERSION=:6.0.0
16+
FROM gcr.io/bazel-public/bazel${BAZEL_VERSION} AS build
1717
COPY . .
1818
RUN bazel build //java/com/google/copybara:copybara_deploy.jar
1919

ci.Dockerfile

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15+
ARG BAZEL_VERSION
1516
FROM gcr.io/bazel-public/bazel${BAZEL_VERSION} AS build
1617
COPY . .
1718
USER root

0 commit comments

Comments
 (0)