Throw ValidationException when +2 is restricted

We should throw validationException instead of reposException when
setReview for +2 on the gerrit change is restricted. This is usually a user error.

PiperOrigin-RevId: 355635497
Change-Id: I94c387dd0ce70c720bd45d9eb420ed64f656d15d

Author: qfc

java/com/google/copybara/git/GerritDestination.java

@@ -315,6 +315,11 @@ private void submitChange(String changeId)
         ChangeInfo resultInfo =
             gerritApi.submitChange(changeInfo.getChangeId(), new SubmitInput(null));
         console.infoFmt("Submitted change : %s/changes/%s", repoUrl, resultInfo.getChangeId());
+      } catch(RepoException e) {
+        if (e.getMessage().contains("2 is restricted")) {
+          throw new ValidationException(e.getMessage(), e);
+        }
+        throw e;
       }
     }
 

javatests/com/google/copybara/git/GerritDestinationTest.java

@@ -717,6 +717,64 @@ public void gerritSubmit_success() throws Exception {
 
   }
 
+  @Test
+  public void gerritSubmit_plusTwoRestricted() throws Exception {
+    options.gerrit.gerritChangeId = null;
+    fetch = "master";
+    writeFile(workdir, "file", "some content");
+    url = BASE_URL + "/foo/bar";
+    repoGitDir = gitUtil.mockRemoteRepo("user:[email protected]/foo/bar").getGitDir();
+    gitUtil.mockApi(eq("GET"), startsWith(BASE_URL +  "/changes/"),
+        mockResponse(
+            "["
+                + "{"
+                + "  change_id : \"Iaaaaaaaaaabbbbbbbbbbccccccccccdddddddddd\","
+                + "  status : \"NEW\""
+                + "}]")
+    );
+    AtomicBoolean submitCalled = new AtomicBoolean(false);
+    AtomicBoolean reviewCalled = new AtomicBoolean(false);
+    gitUtil.mockApi(
+        eq("POST"),
+        matches(BASE_URL + "/changes/.*/revisions/.*/review"),
+        mockResponseWithStatus("Applying label \\\"Code-Review\\\": 2 is restricted\\n\\n", 401));
+
+    gitUtil.mockApi(
+        eq("POST"),
+        matches(BASE_URL + "/changes/.*/submit"),
+        mockResponseAndValidateRequest(
+            "{"
+                + "  change_id : \"Iaaaaaaaaaabbbbbbbbbbccccccccccdddddddddd\","
+                + "  status : \"submitted\""
+                + "}",
+            new MockRequestAssertion("Always true with side-effect",
+                s -> {
+                  submitCalled.set(true);
+                  return true;
+                }))
+    );
+
+    options.setForce(true);
+    DummyRevision originRef = new DummyRevision("origin_ref");
+    GerritDestination destination = destination("submit = True", "gerrit_submit = True");
+    Glob glob = Glob.createGlob(ImmutableList.of("**"), excludedDestinationPaths);
+    WriterContext writerContext =
+        new WriterContext("GerritDestinationTest", "test", false, originRef,
+            Glob.ALL_FILES.roots());
+    ValidationException validationException =
+        assertThrows(ValidationException.class,
+            () ->  destination
+              .newWriter(writerContext)
+              .write(
+                  TransformResults.of(workdir, originRef)
+                      .withSummary("Test message")
+                      .withIdentity(originRef.asString()),
+                  glob,
+                  console));
+
+    assertThat(validationException).hasMessageThat().contains("2 is restricted");
+  }
+
   @Test
   public void gerritSubmit_noChange() throws Exception {
     options.gerrit.gerritChangeId = null;